Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arbitrum local testnet setup #205

Merged
merged 74 commits into from
Jan 19, 2024
Merged

Arbitrum local testnet setup #205

merged 74 commits into from
Jan 19, 2024

Conversation

ManojJiSharma
Copy link
Contributor

@ManojJiSharma ManojJiSharma commented Dec 7, 2023 •
edited
Loading

  • Arbitrum setup on local
  • Unit test cases
  • Add workflow/Action

@ManojJiSharma ManojJiSharma linked an issue Dec 7, 2023 that may be closed by this pull request
Arbitrum local testnet setup #193
Closed
4 tasks
@ManojJiSharma ManojJiSharma self-assigned this Dec 11, 2023
@ManojJiSharma ManojJiSharma marked this pull request as ready for review December 12, 2023 09:38
@ManojJiSharma ManojJiSharma requested a review from Lohann December 12, 2023 09:38
Lohann
Lohann requested changes Dec 12, 2023
View reviewed changes
chains/arbitrum/config/Cargo.toml Outdated Show resolved Hide resolved
chains/arbitrum/server/Cargo.toml Outdated Show resolved Hide resolved
chains/arbitrum/testing/rosetta-testing-arbitrum/Cargo.toml Outdated Show resolved Hide resolved
chains/arbitrum/testing/rosetta-testing-arbitrum/src/lib.rs Outdated Show resolved Hide resolved
chains/arbitrum/testing/rosetta-testing-arbitrum/src/lib.rs Show resolved Hide resolved
chains/arbitrum/config/src/lib.rs Outdated Show resolved Hide resolved
chains/ethereum/server/src/client.rs Outdated Show resolved Hide resolved
@ManojJiSharma ManojJiSharma requested a review from Lohann December 29, 2023 11:22
Lohann
Lohann requested changes Dec 29, 2023
View reviewed changes
chains/arbitrum/server/src/lib.rs Outdated Show resolved Hide resolved
chains/arbitrum/testing/rosetta-testing-arbitrum/Cargo.toml Outdated Show resolved Hide resolved
rosetta-client/src/client.rs Outdated Show resolved Hide resolved
chains/ethereum/server/src/client.rs Outdated Show resolved Hide resolved
@ManojJiSharma ManojJiSharma requested a review from Lohann January 1, 2024 10:28
@0x1100010010 0x1100010010 linked an issue Jan 1, 2024 that may be closed by this pull request
Arbitrum Connector Unit Tests #194
Closed
1 task
Lohann
Lohann requested changes Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@Lohann Lohann left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do a test please? in the .github/workflows/ci.yaml replace all occurrences of:

runs-on: self-hosted

by this:

runs-on: ubuntu-latest

I want to check if those tests passes in an empty vm, because currently the self-hosted doesn't start in a clean state.

.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
Lohann
Lohann reviewed Jan 10, 2024
View reviewed changes
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
@ManojJiSharma ManojJiSharma requested a review from Lohann January 16, 2024 11:55
@Lohann
Copy link
Collaborator

Lohann commented Jan 18, 2024 •
edited
Loading

Need to update this branch with latest master, then run cargo update and commit the updated Cargo.lock file.

@ManojJiSharma ManojJiSharma merged commit d6301e0 into master Jan 19, 2024
8 checks passed
@ManojJiSharma ManojJiSharma deleted the arbitrum_local_testnet_setup branch January 19, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lohann Lohann Lohann approved these changes

Assignees

@ManojJiSharma ManojJiSharma

Labels
ready-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Arbitrum Connector Unit Tests Arbitrum local testnet setup
2 participants
@ManojJiSharma @Lohann