Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry forever #277

Merged
merged 11 commits into from
Jan 31, 2025
Merged

Retry forever #277

merged 11 commits into from
Jan 31, 2025

Conversation

Lohann
Copy link
Collaborator

@Lohann Lohann commented Jan 30, 2025

Description

Temporary fix for improve tx reliability.

This algorithm fails and may deadlock the system in the following scenarios:

  1. The chronicle crashes or restarts while waiting for a pending transaction
  2. Any transaction retracts after 5 confirmations (very rare in most chains).
  3. The pending tx is replaced by another transaction not managed by this chronicle instance, in this case it will try to get the tx_receipt forever.
  4. The gas fee estimation failed miserably, and the latest 10 blocks 90% percentile is not suficiente to represent the real fee.
  5. the system deadlock if any transaction is invalid (cannot be submitted) or fails to be submitted in the first attempt.

@Lohann Lohann requested a review from haider-rs January 30, 2025 16:52
@Lohann
Copy link
Collaborator Author

Lohann commented Jan 30, 2025

Damn.. I already upgraded everything to 1.84, In the next life I'll use nixos on CI. @penumbra23 any clues?

rustc 1.79.0 is not supported by the following packages:
    [email protected] requires rustc 1.81
    [email protected] requires rustc 1.81
    [email protected] requires rustc 1.81
    [email protected] requires rustc 1.81

@penumbra23
Copy link
Contributor

Damn.. I already upgraded everything to 1.84, In the next life I'll use nixos on CI. @penumbra23 any clues?

rustc 1.79.0 is not supported by the following packages:
    [email protected] requires rustc 1.81
    [email protected] requires rustc 1.81
    [email protected] requires rustc 1.81
    [email protected] requires rustc 1.81

Timechain is upgraded to 1.81.0, seems some deps have moved on so let me upgrade Rust on the runner

@Lohann
Copy link
Collaborator Author

Lohann commented Jan 30, 2025

Ok, will downgrade to 1.81 to match timechain version.

@Lohann Lohann merged commit f614446 into master Jan 31, 2025
8 of 11 checks passed
@Lohann Lohann deleted the lpcf/temporary-fix-nonce branch January 31, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants