block_stream: remove state handling for orphaned blocks #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the internal
BlockStreamstate management and re-balancing of the orphaned blocks. The reason for this change is because it turns out that the internals cause a memory leak (or better to say memory misuse) described in THIS issue.Test
I've updated the chronicle to point to the last commit of this branch and run it on integration environment for 3 days, here are the results:
The updated 3 chronicles use a stable 30MB during the period of testing, while the old ones are taking up the whole node (3-4GB).
Additional Information
Because I'm not familiar with this part and I haven't tested ALL cases of a shard working with this change, @Lohann can you point out what this code does and what are the implications of removing it?