Add when argument to define-obsolete-function-alias #1410
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `when` has become mandatory since https://emba.gnu.org/emacs/emacs/-/commit/32c6732d16385f242b1109517f25e9aefd6caa5c (credit to @zflat). Fortunately the emacs-24.3 (the lowest supported version according to package), has already support for the `when` parameter. I've used `v2.2` as this is the tag that follows commit that added the obsolete call (dbf1ca3).
Andersbakken
approved these changes
Mar 30, 2021
|
Thanks. Sorry about the delay. |
|
Not sure why the PR got closed without merging but I manually merged the change from your branch. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
whenhas become mandatory since https://emba.gnu.org/emacs/emacs/-/commit/32c6732d16385f242b1109517f25e9aefd6caa5c (credit to @zflat).Fortunately the emacs-24.3 (the lowest supported version according to package), has already support for the
whenparameter.I've used
v2.2as this is the tag that follows commit that added the obsole call (dbf1ca3).fixes #1408