feat: Frax middleman example #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
82
to
110
| function incentivizePool( | ||
| address poolAddress, | ||
| address, | ||
| address, | ||
| address incentiveTokenAddress, | ||
| uint256, | ||
| uint256 amount | ||
| ) external { | ||
| IERC20(incentiveTokenAddress).safeTransferFrom(msg.sender, address(this), amount); | ||
| DistributionParameters memory params = gaugeParams[poolAddress][incentiveTokenAddress]; | ||
| if (params.uniV3Pool == address(0)) revert InvalidParams(); | ||
| DistributionCreator creator = merklDistributionCreator(); | ||
| // Minimum amount of incentive tokens to be distributed per hour | ||
| uint256 minAmount = creator.rewardTokenMinAmounts(incentiveTokenAddress) * params.numEpoch; | ||
| params.epochStart = uint32(block.timestamp); | ||
| // Adding the leftover amounts to the total amount to be distributed | ||
| uint256 leftover = leftovers[incentiveTokenAddress][poolAddress]; | ||
| amount += leftover; | ||
| params.amount = amount; | ||
| if (amount > 0) { | ||
| if (amount > minAmount) { | ||
| _handleIncentiveTokenAllowance(IERC20(incentiveTokenAddress), address(creator), amount); | ||
| merklDistributionCreator().createDistribution(params); | ||
| if (leftover > 0) leftovers[incentiveTokenAddress][poolAddress] = 0; | ||
| } else { | ||
| leftovers[incentiveTokenAddress][poolAddress] = amount; | ||
| } | ||
| } | ||
| } |
Check warning
Code scanning / Slither
Unused return
Comment on lines
+75
to
+77
| function setOperator(address _operatorAddress) external onlyByOwnerOperator { | ||
| operatorAddress = _operatorAddress; | ||
| } |
Check notice
Code scanning / Slither
Missing events access control
| } | ||
|
|
||
| /// @notice Sets the operator of the contract | ||
| function setOperator(address _operatorAddress) external onlyByOwnerOperator { |
Check notice
Code scanning / Slither
Missing zero address validation
Comment on lines
82
to
110
| function incentivizePool( | ||
| address poolAddress, | ||
| address, | ||
| address, | ||
| address incentiveTokenAddress, | ||
| uint256, | ||
| uint256 amount | ||
| ) external { | ||
| IERC20(incentiveTokenAddress).safeTransferFrom(msg.sender, address(this), amount); | ||
| DistributionParameters memory params = gaugeParams[poolAddress][incentiveTokenAddress]; | ||
| if (params.uniV3Pool == address(0)) revert InvalidParams(); | ||
| DistributionCreator creator = merklDistributionCreator(); | ||
| // Minimum amount of incentive tokens to be distributed per hour | ||
| uint256 minAmount = creator.rewardTokenMinAmounts(incentiveTokenAddress) * params.numEpoch; | ||
| params.epochStart = uint32(block.timestamp); | ||
| // Adding the leftover amounts to the total amount to be distributed | ||
| uint256 leftover = leftovers[incentiveTokenAddress][poolAddress]; | ||
| amount += leftover; | ||
| params.amount = amount; | ||
| if (amount > 0) { | ||
| if (amount > minAmount) { | ||
| _handleIncentiveTokenAllowance(IERC20(incentiveTokenAddress), address(creator), amount); | ||
| merklDistributionCreator().createDistribution(params); | ||
| if (leftover > 0) leftovers[incentiveTokenAddress][poolAddress] = 0; | ||
| } else { | ||
| leftovers[incentiveTokenAddress][poolAddress] = amount; | ||
| } | ||
| } | ||
| } |
Check notice
Code scanning / Slither
Reentrancy vulnerabilities
sogipec
force-pushed
the
frax-incentivizor-handler
branch
from
ebcf76c to
ce72f26
Compare
Picodes
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.