Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: low hanging fruits #32

Merged
merged 11 commits into from
Dec 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 13 additions & 36 deletions merkl.config.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { createColoring } from "dappkit";
import { createConfig } from "src/config/type";
import { http } from "viem";
import { createClient, custom, http } from "viem";
import {
mainnet,
optimism,
Expand Down Expand Up @@ -37,33 +37,19 @@ import {
} from "viem/chains";
import { coinbaseWallet, walletConnect } from "wagmi/connectors";
import hero from "src/customer/assets/images/hero.jpg?url";
import { eip712WalletActions } from "viem/zksync";

export default createConfig({
appName: "Merkl",
modes: ["dark", "light"],
defaultTheme: "merkl",
themes: {
merkl: {
base: createColoring(
["#1F2333", "#B8AAFD", "#131620"],
["#FCF8F5", "#B8AAFD", "white"]
),
info: createColoring(
["#2ABDFF", "#2ABDFF", "#131620"],
["#FFFFFF", "#40B66B", "white"]
),
good: createColoring(
["#40B66B", "#40B66B", "#131620"],
["#FFFFFF", "#40B66B", "white"]
),
warn: createColoring(
["#ff9600", "#ff9600", "#131620"],
["#FFFFFF", "#40B66B", "white"]
),
harm: createColoring(
["#d22e14", "#d22e14", "#131620"],
["#FFFFFF", "#40B66B", "white"]
),
base: createColoring(["#1F2333", "#B8AAFD", "#131620"], ["#FCF8F5", "#B8AAFD", "white"]),
info: createColoring(["#2ABDFF", "#2ABDFF", "#131620"], ["#FFFFFF", "#40B66B", "white"]),
good: createColoring(["#40B66B", "#40B66B", "#131620"], ["#FFFFFF", "#40B66B", "white"]),
warn: createColoring(["#ff9600", "#ff9600", "#131620"], ["#FFFFFF", "#40B66B", "white"]),
harm: createColoring(["#d22e14", "#d22e14", "#131620"], ["#FFFFFF", "#40B66B", "white"]),
},
},
sizing: {
Expand All @@ -80,11 +66,6 @@ export default createConfig({
route: "/",
key: crypto.randomUUID(),
},
dashboard: {
icon: "RiDashboard2Fill",
route: "/user",
key: crypto.randomUUID(),
},
opportunities: {
icon: "RiPlanetFill",
route: "/opportunities",
Expand All @@ -95,12 +76,6 @@ export default createConfig({
route: "/protocols",
key: crypto.randomUUID(),
},
bridge: {
icon: "RiVipCrown2Fill",
route: "/bridge",
key: crypto.randomUUID(),
},
faq: { icon: "RiQuestionFill", route: "/faq", key: crypto.randomUUID() },
terms: {
icon: "RiCompassesLine",
route: "/terms",
Expand Down Expand Up @@ -156,6 +131,12 @@ export default createConfig({
taiko,
scroll,
],
client({ chain }) {
if (chain.id === zksync.id)
return createClient({ chain, transport: custom(window.ethereum!) }).extend(eip712WalletActions());
return createClient({ chain, transport: http() });
},
ssr: true,
connectors: [
coinbaseWallet(),
walletConnect({
Expand All @@ -169,9 +150,5 @@ export default createConfig({
},
}),
],
transports: {
[zksync.id]: http(),
[optimism.id]: http(),
},
},
});
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
],
"dependencies": {
"@acab/ecsstatic": "^0.8.0",
"@angleprotocol/merkl-api": "0.10.69",
"@merkl/api": "0.10.78",
"@ariakit/react": "^0.4.12",
"@elysiajs/eden": "^1.1.3",
"@emotion/css": "^11.13.4",
Expand Down
2 changes: 1 addition & 1 deletion packages/dappkit
Submodule dappkit updated 50 files
+50 −0 LICENSE.md
+78 −32 README.md
+4 −3 package.json
+3 −1 src/components.ts
+2 −2 src/components/VisuallyHidden.tsx
+4 −5 src/components/dapp/Countdown.tsx
+4 −9 src/components/dapp/TransactionButton.tsx
+7 −11 src/components/dapp/TransactionHelper.tsx
+34 −35 src/components/dapp/WalletButton.tsx
+1 −1 src/components/dapp/WalletConnectors.tsx
+8 −13 src/components/extenders/Card.tsx
+8 −5 src/components/extenders/Dropdown.tsx
+1 −3 src/components/extenders/Group.tsx
+3 −3 src/components/extenders/Modal.tsx
+38 −68 src/components/extenders/Select.tsx
+3 −11 src/components/layout/Container.tsx
+8 −29 src/components/primitives/Accordion.tsx
+1 −1 src/components/primitives/Bar.tsx
+37 −39 src/components/primitives/Button.tsx
+4 −17 src/components/primitives/Checkbox.tsx
+4 −11 src/components/primitives/Collapsible.tsx
+3 −19 src/components/primitives/Divider.tsx
+13 −26 src/components/primitives/Hash.tsx
+5 −28 src/components/primitives/Icon.tsx
+40 −69 src/components/primitives/Input.tsx
+1 −1 src/components/primitives/List.tsx
+67 −0 src/components/primitives/PrimitiveTag.tsx
+2 −5 src/components/primitives/Scroll.tsx
+7 −25 src/components/primitives/Slider.tsx
+22 −65 src/components/primitives/Table.tsx
+8 −24 src/components/primitives/Text.tsx
+23 −64 src/components/primitives/Title.tsx
+4 −9 src/components/primitives/Tooltip.tsx
+17 −23 src/components/primitives/Value.tsx
+25 −100 src/config/themes.ts
+19 −6 src/context/Dapp.context.tsx
+32 −37 src/context/Theme.context.tsx
+7 −5 src/context/Wallet.context.tsx
+2 −7 src/hooks/theming/OverrideTheme.tsx
+3 −3 src/hooks/theming/useThemableProps.tsx
+4 −13 src/hooks/theming/useThemedVariables.tsx
+23 −21 src/hooks/useClipboard.tsx
+16 −29 src/hooks/useWalletState.tsx
+4 −4 src/index.ts
+5 −12 src/style.css
+0 −49 src/theme/variabless.ts
+4 −4 src/theming/coloring.ts
+9 −7 src/utils/event.ts
+9 −9 src/utils/react.ts
+15 −18 src/utils/tailwind.ts
2 changes: 1 addition & 1 deletion src/api/index.client.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { MerklApi } from "@angleprotocol/merkl-api";
import { MerklApi } from "@merkl/api";

const api = MerklApi((window as { ENV?: { API_URL?: string } })?.ENV?.API_URL ?? "https://api.merkl.xyz");

Expand Down
2 changes: 1 addition & 1 deletion src/api/index.server.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { MerklApi } from "@angleprotocol/merkl-api";
import { MerklApi } from "@merkl/api";

const api = MerklApi(process.env.API_URL ?? "https://api.merkl.xyz");

Expand Down
2 changes: 1 addition & 1 deletion src/api/services/chain.service.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { Chain } from "@angleprotocol/merkl-api";
import type { Chain } from "@merkl/api";
import { api } from "../index.server";

export abstract class ChainService {
Expand Down
9 changes: 6 additions & 3 deletions src/api/services/opportunity.service.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { Opportunity } from "@angleprotocol/merkl-api";
import type { Opportunity } from "@merkl/api";
import config from "merkl.config";
import { api } from "../index.server";

Expand Down Expand Up @@ -48,8 +48,11 @@ export abstract class OpportunityService {
return query;
}

static async getManyFromRequest(request: Request) {
return OpportunityService.getMany(OpportunityService.#getQueryFromRequest(request));
static async getManyFromRequest(
request: Request,
overrides?: Parameters<typeof api.v4.opportunities.index.get>[0]["query"],
) {
return OpportunityService.getMany(Object.assign(OpportunityService.#getQueryFromRequest(request), overrides ?? {}));
}

static async getMany(
Expand Down
40 changes: 39 additions & 1 deletion src/api/services/protocol.service.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { Protocol } from "@angleprotocol/merkl-api";
import type { Protocol } from "@merkl/api";
import { api } from "../index.server";

export abstract class ProtocolService {
Expand All @@ -14,9 +14,47 @@ export abstract class ProtocolService {
return data;
}

/**
* Retrieves protocols query params from page request
* @param request request containing query params such as paginatio
* @param override params for which to override value
* @returns query
*/
static #getQueryFromRequest(
request: Request,
override?: Parameters<typeof api.v4.opportunities.index.get>[0]["query"],
) {
const page = new URL(request.url).searchParams.get("page");
const items = new URL(request.url).searchParams.get("items");
const search = new URL(request.url).searchParams.get("search");

const [sort, order] = new URL(request.url).searchParams.get("sort")?.split("-") ?? [];

const filters = Object.assign(
{ items, sort, order, name: search, page },
override ?? {},
page !== null && { page: Number(page) - 1 },
);

const query = Object.entries(filters).reduce(
(_query, [key, filter]) => Object.assign(_query, filter == null ? {} : { [key]: filter }),
{},
);

return query;
}

static async get(query: { id: string }): Promise<Protocol> {
const protocol = await ProtocolService.#fetch(async () => api.v4.protocols(query).get({ query }));

return protocol;
}

static async getManyFromRequest(request: Request): Promise<{ protocols: Protocol[]; count: number }> {
const query = ProtocolService.#getQueryFromRequest(request);
const protocols = await ProtocolService.#fetch(async () => api.v4.protocols.index.get({ query }));
const count = await ProtocolService.#fetch(async () => api.v4.protocols.count.get({ query }));

return { protocols, count };
}
}
2 changes: 1 addition & 1 deletion src/api/services/reward.service.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { Reward } from "@angleprotocol/merkl-api";
import type { Reward } from "@merkl/api";
import { api } from "../index.server";

export abstract class RewardService {
Expand Down
42 changes: 40 additions & 2 deletions src/api/services/token.service.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import type { Token } from "@angleprotocol/merkl-api";
import type { Token } from "@merkl/api";
import { api } from "../index.server";

export abstract class TokenService {
static async #fetch<R, T extends { data: R; status: number }>(
call: () => Promise<T>,
resource = "Chain",
resource = "Token",
): Promise<NonNullable<T["data"]>> {
const { data, status } = await call();

Expand All @@ -14,6 +14,44 @@ export abstract class TokenService {
return data;
}

/**
* Retrieves tokens query params from page request
* @param request request containing query params such as pagination
* @param override params for which to override value
* @returns query
*/
static #getQueryFromRequest(
request: Request,
override?: Parameters<typeof api.v4.opportunities.index.get>[0]["query"],
) {
const page = new URL(request.url).searchParams.get("page");
const items = new URL(request.url).searchParams.get("items");
const search = new URL(request.url).searchParams.get("search");

const [sort, order] = new URL(request.url).searchParams.get("sort")?.split("-") ?? [];

const filters = Object.assign(
{ items, sort, order, name: search, page },
override ?? {},
page !== null && { page: Number(page) - 1 },
);

const query = Object.entries(filters).reduce(
(_query, [key, filter]) => Object.assign(_query, filter == null ? {} : { [key]: filter }),
{},
);

return query;
}

static async getManyFromRequest(request: Request): Promise<{ tokens: Token[]; count: number }> {
const query = TokenService.#getQueryFromRequest(request);
const tokens = await TokenService.#fetch(async () => api.v4.tokens.index.get({ query }));
const count = await TokenService.#fetch(async () => api.v4.tokens.count.get({ query }));

return { tokens, count };
}

static async getMany(query: Parameters<typeof api.v4.tokens.index.get>[0]["query"]): Promise<Token[]> {
const tokens = await TokenService.#fetch(async () => api.v4.tokens.index.get({ query }));

Expand Down
2 changes: 1 addition & 1 deletion src/api/types.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
import type { MerklApi } from "@angleprotocol/merkl-api";
import type { MerklApi } from "@merkl/api";

export type Api = ReturnType<typeof MerklApi>;
Loading
Loading