CSharp Performance: don't decrease list capacities when reusing clipper objects #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ets the internal lists capacity, even if the capacity already sufficient. This causes C# to drop the currently allocated array and create a new, smaller one. This changes check if the capacity is sufficient before setting it to reduces allocations.
jiajuncccc
added a commit
to jiajuncccc/Clipper2
that referenced
this pull request
Dec 20, 2023
* remotes/upstream/main: Minor code tidy of variable offset example CSharp Performance: when reusing clipper objects, currently clipper sets the internal lists capacity, even if the capacity already sufficient. This causes C# to drop the currently allocated array and create a new, smaller one. (AngusJohnson#750)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSharp Performance: when reusing clipper objects, currently clipper sets the internal lists capacity, even if the capacity is already sufficient. This causes C# to drop the currently allocated array and create a new, smaller one (If clipper is not reused this is fine).
This merge request contains changes that check if the capacity is sufficient before setting it to reduce allocations.
I have conducted a benchmark (using BenchmarkDotNet) of my application that reuses clipper objects. This small change reduces allocations by 15% and also slightly improves runtimes.