chore!(code structure): Split the script functions into separate libraries #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aries Split the functions inside the main script into their own separate libraries scripts to improve readability and ease the overall maintenance and contribution processes. Closes #230 BREAKING CHANGE: The python script for the systray applet is now sourced as a library by the main script (and not executed from `"installation_prefix"/bin/` anymore). People that installed Arch-Update from source will have to either uninstall it (with `make uninstall`) **before** pulling and installing the new version (with `make install`), or they will have to manually remove the `arch-update-tray` file from their system (which is under `/usr/local/bin/` if the default installation prefix was used) after upgrading from `v2.x.x` to `v3.x.x`. Otherwise, the `arch-update-tray` file will remain un-tracked on the system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Split the functions inside the main script into their own separate libraries scripts to improve readability and ease the overall maintenance and contribution processes.
BREAKING CHANGE: The python script for the systray applet is now sourced as a library by the main script (and not executed from
"installation_prefix"/bin/anymore). People that installed Arch-Update from source will have to either uninstall it (withmake uninstall) before pulling and installing the new version (withmake install), or they will have to manually remove thearch-update-trayfile from their system (which is under/usr/local/bin/if the default installation prefix was used) after upgrading fromv2.x.xtov3.x.x. Otherwise, thearch-update-trayfile will remain un-tracked on the system.Addressed feature request
Closes #230