Merge pull request #156 from AntonioFalcao/feature/code-smells

Backing field collections
AntonioFalcaoJr · Mar 10, 2021 · 7f3d917 · 7f3d917
2 parents c9ca840 + d02330d
commit 7f3d917
Show file tree

Hide file tree

Showing 16 changed files with 1,757 additions and 1,764 deletions.
diff --git a/src/Dotnet5.GraphQL3.CrossCutting/Dotnet5.GraphQL3.CrossCutting.csproj b/src/Dotnet5.GraphQL3.CrossCutting/Dotnet5.GraphQL3.CrossCutting.csproj
@@ -1,10 +1,8 @@
 <Project Sdk="Microsoft.NET.Sdk">
-
     <ItemGroup>
-        <PackageReference Include="FluentValidation" Version="$(FluentValidation_Version)" />
-        <PackageReference Include="GraphQL" Version="$(GraphQL_Version)" />
-        <PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="$(Microsoft_DependencyInjection_Version)" />
-        <PackageReference Include="Microsoft.Extensions.DependencyModel" Version="3.1.6" />
+        <PackageReference Include="FluentValidation" Version="$(FluentValidation_Version)"/>
+        <PackageReference Include="GraphQL" Version="$(GraphQL_Version)"/>
+        <PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="$(Microsoft_DependencyInjection_Version)"/>
+        <PackageReference Include="Microsoft.Extensions.DependencyModel" Version="3.1.6"/>
     </ItemGroup>
-
 </Project>
diff --git a/src/Dotnet5.GraphQL3.Domain.Abstractions/Dotnet5.GraphQL3.Domain.Abstractions.csproj b/src/Dotnet5.GraphQL3.Domain.Abstractions/Dotnet5.GraphQL3.Domain.Abstractions.csproj
@@ -1,13 +1,10 @@
 <Project Sdk="Microsoft.NET.Sdk">
-
     <ItemGroup>
-        <PackageReference Include="FluentValidation" Version="$(FluentValidation_Version)" />
-        <PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="$(Microsoft_DependencyInjection_Version)" />
-        <PackageReference Include="Scrutor" Version="$(Scrutor_Version)" />
+        <PackageReference Include="FluentValidation" Version="$(FluentValidation_Version)"/>
+        <PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="$(Microsoft_DependencyInjection_Version)"/>
+        <PackageReference Include="Scrutor" Version="$(Scrutor_Version)"/>
     </ItemGroup>
-
     <ItemGroup>
-      <ProjectReference Include="..\Dotnet5.GraphQL3.CrossCutting\Dotnet5.GraphQL3.CrossCutting.csproj" />
+        <ProjectReference Include="..\Dotnet5.GraphQL3.CrossCutting\Dotnet5.GraphQL3.CrossCutting.csproj"/>
     </ItemGroup>
-
 </Project>
diff --git a/...net5.GraphQL3.Repositories.Abstractions/Dotnet5.GraphQL3.Repositories.Abstractions.csproj b/...net5.GraphQL3.Repositories.Abstractions/Dotnet5.GraphQL3.Repositories.Abstractions.csproj
@@ -1,13 +1,10 @@
 <Project Sdk="Microsoft.NET.Sdk">
-
     <ItemGroup>
-        <PackageReference Include="AutoMapper" Version="$(AutoMapper_Version)" />
-        <PackageReference Include="Microsoft.EntityFrameworkCore" Version="$(Microsoft_EntityFrameworkCore_Version)" />
-        <PackageReference Include="Scrutor" Version="$(Scrutor_Version)" />
+        <PackageReference Include="AutoMapper" Version="$(AutoMapper_Version)"/>
+        <PackageReference Include="Microsoft.EntityFrameworkCore" Version="$(Microsoft_EntityFrameworkCore_Version)"/>
+        <PackageReference Include="Scrutor" Version="$(Scrutor_Version)"/>
     </ItemGroup>
-
     <ItemGroup>
-        <ProjectReference Include="..\Dotnet5.GraphQL3.Store.Domain\Dotnet5.GraphQL3.Store.Domain.csproj" />
+        <ProjectReference Include="..\Dotnet5.GraphQL3.Store.Domain\Dotnet5.GraphQL3.Store.Domain.csproj"/>
     </ItemGroup>
-
 </Project>
diff --git a/src/Dotnet5.GraphQL3.Services.Abstractions/Dotnet5.GraphQL3.Services.Abstractions.csproj b/src/Dotnet5.GraphQL3.Services.Abstractions/Dotnet5.GraphQL3.Services.Abstractions.csproj
@@ -1,16 +1,14 @@
 <Project Sdk="Microsoft.NET.Sdk">
-
     <ItemGroup>
-        <PackageReference Include="AutoMapper" Version="$(AutoMapper_Version)" />
-        <PackageReference Include="AutoMapper.Extensions.Microsoft.DependencyInjection" Version="$(AutoMapper_DependencyInjection_Version)" />
-        <PackageReference Include="Microsoft.EntityFrameworkCore" Version="$(Microsoft_EntityFrameworkCore_Version)" />
-        <PackageReference Include="Scrutor" Version="$(Scrutor_Version)" />
+        <PackageReference Include="AutoMapper" Version="$(AutoMapper_Version)"/>
+        <PackageReference Include="AutoMapper.Extensions.Microsoft.DependencyInjection" Version="$(AutoMapper_DependencyInjection_Version)"/>
+        <PackageReference Include="Microsoft.EntityFrameworkCore" Version="$(Microsoft_EntityFrameworkCore_Version)"/>
+        <PackageReference Include="Scrutor" Version="$(Scrutor_Version)"/>
     </ItemGroup>
-
     <ItemGroup>
-        <ProjectReference Include="..\Dotnet5.GraphQL3.CrossCutting\Dotnet5.GraphQL3.CrossCutting.csproj" />
-        <ProjectReference Include="..\Dotnet5.GraphQL3.Repositories.Abstractions\Dotnet5.GraphQL3.Repositories.Abstractions.csproj" />
-        <ProjectReference Include="..\Dotnet5.GraphQL3.Store.Domain\Dotnet5.GraphQL3.Store.Domain.csproj" />
+        <ProjectReference Include="..\Dotnet5.GraphQL3.CrossCutting\Dotnet5.GraphQL3.CrossCutting.csproj"/>
+        <ProjectReference Include="..\Dotnet5.GraphQL3.Repositories.Abstractions\Dotnet5.GraphQL3.Repositories.Abstractions.csproj"/>
+        <ProjectReference Include="..\Dotnet5.GraphQL3.Store.Domain\Dotnet5.GraphQL3.Store.Domain.csproj"/>
     </ItemGroup>
 
     <ItemGroup>

diff --git a/src/Dotnet5.GraphQL3.Store.Domain/Dotnet5.GraphQL3.Store.Domain.csproj b/src/Dotnet5.GraphQL3.Store.Domain/Dotnet5.GraphQL3.Store.Domain.csproj
@@ -1,26 +1,21 @@
 <Project Sdk="Microsoft.NET.Sdk">
-
     <ItemGroup>
-        <PackageReference Include="FluentValidation" Version="$(FluentValidation_Version)" />
+        <PackageReference Include="FluentValidation" Version="$(FluentValidation_Version)"/>
+    </ItemGroup>
+    <ItemGroup>
+        <ProjectReference Include="..\Dotnet5.GraphQL3.Domain.Abstractions\Dotnet5.GraphQL3.Domain.Abstractions.csproj"/>
     </ItemGroup>
-
     <ItemGroup>
         <EmbeddedResource Update="Resource.resx">
             <Generator>ResXFileCodeGenerator</Generator>
             <LastGenOutput>Resource.Designer.cs</LastGenOutput>
         </EmbeddedResource>
     </ItemGroup>
-
     <ItemGroup>
         <Compile Update="Resource.Designer.cs">
             <DesignTime>True</DesignTime>
             <AutoGen>True</AutoGen>
             <DependentUpon>DomainResource.resx</DependentUpon>
         </Compile>
     </ItemGroup>
-
-    <ItemGroup>
-        <ProjectReference Include="..\Dotnet5.GraphQL3.Domain.Abstractions\Dotnet5.GraphQL3.Domain.Abstractions.csproj" />
-    </ItemGroup>
-
 </Project>
diff --git a/src/Dotnet5.GraphQL3.Store.Domain/Entities/Products/Product.cs b/src/Dotnet5.GraphQL3.Store.Domain/Entities/Products/Product.cs
@@ -9,8 +9,9 @@ namespace Dotnet5.GraphQL3.Store.Domain.Entities.Products
 {
     public abstract class Product : Entity<Guid>, IProduct
     {
-        protected Product(Guid id, string description, DateTimeOffset introduceAt, string name, string photoUrl, decimal price,
-            ProductType productType, int rating, int stock, Option option)
+        private readonly HashSet<Review> _reviews = new();
+
+        protected Product(Guid id, string description, DateTimeOffset introduceAt, string name, string photoUrl, decimal price, ProductType productType, int rating, int stock, Option option)
         {
             Id = id;
             Description = description;
@@ -22,11 +23,13 @@ protected Product(Guid id, string description, DateTimeOffset introduceAt, strin
             Rating = rating;
             Stock = stock;
             Option = option;
-            Reviews = new List<Review>();
         }
 
         protected Product() { }
 
+        public IReadOnlyCollection<Review> Reviews
+             => _reviews;
+
         public string Description { get; }
         public DateTimeOffset IntroduceAt { get; }
         public string Name { get; }
@@ -36,7 +39,6 @@ protected Product() { }
         public ProductType ProductType { get; }
         public int Rating { get; }
         public int Stock { get; }
-        public ICollection<Review> Reviews { get; }
 
         public void AddReview(Review review)
         {
@@ -46,8 +48,8 @@ public void AddReview(Review review)
                 return;
             }
 
-            if (Reviews.Contains(review)) return;
-            Reviews.Add(review);
+            if (_reviews.Contains(review)) return;
+            _reviews.Add(review);
         }
     }
 }
diff --git a/src/Dotnet5.GraphQL3.Store.Repositories/Contexts/StoreDbContext.cs b/src/Dotnet5.GraphQL3.Store.Repositories/Contexts/StoreDbContext.cs
@@ -7,6 +7,8 @@ namespace Dotnet5.GraphQL3.Store.Repositories.Contexts
 {
     public class StoreDbContext : DbContext
     {
+        private const string SqlLatin1GeneralCp1CsAs = "SQL_Latin1_General_CP1_CS_AS";
+
         public StoreDbContext(DbContextOptions options)
             : base(options) { }
 
@@ -16,7 +18,7 @@ public StoreDbContext(DbContextOptions options)
 
         protected override void OnModelCreating(ModelBuilder modelBuilder)
         {
-            modelBuilder.UseCollation("SQL_Latin1_General_CP1_CS_AS");
+            modelBuilder.UseCollation(SqlLatin1GeneralCp1CsAs);
             modelBuilder.ApplyConfigurationsFromAssembly(typeof(StoreDbContext).Assembly);
             modelBuilder.Seed();
             base.OnModelCreating(modelBuilder);

diff --git a/src/Dotnet5.GraphQL3.Store.Repositories/Dotnet5.GraphQL3.Store.Repositories.csproj b/src/Dotnet5.GraphQL3.Store.Repositories/Dotnet5.GraphQL3.Store.Repositories.csproj
@@ -1,14 +1,11 @@
 <Project Sdk="Microsoft.NET.Sdk">
-
     <ItemGroup>
-        <PackageReference Include="Bogus" Version="33.0.2" />
-        <PackageReference Include="Microsoft.EntityFrameworkCore.Relational" Version="$(Microsoft_EntityFrameworkCore_Version)" />
-        <PackageReference Include="Microsoft.EntityFrameworkCore.Design" Version="$(Microsoft_EntityFrameworkCore_Version)" />
-        <PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="$(Microsoft_EntityFrameworkCore_Version)" />
+        <PackageReference Include="Bogus" Version="33.0.2"/>
+        <PackageReference Include="Microsoft.EntityFrameworkCore.Relational" Version="$(Microsoft_EntityFrameworkCore_Version)"/>
+        <PackageReference Include="Microsoft.EntityFrameworkCore.Design" Version="$(Microsoft_EntityFrameworkCore_Version)"/>
+        <PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="$(Microsoft_EntityFrameworkCore_Version)"/>
     </ItemGroup>
-
     <ItemGroup>
-        <ProjectReference Include="..\Dotnet5.GraphQL3.Repositories.Abstractions\Dotnet5.GraphQL3.Repositories.Abstractions.csproj" />
+        <ProjectReference Include="..\Dotnet5.GraphQL3.Repositories.Abstractions\Dotnet5.GraphQL3.Repositories.Abstractions.csproj"/>
     </ItemGroup>
-
 </Project>