-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/parse once #185
Bugfix/parse once #185
Conversation
instead of std::string/const char*/thorin::Sym/whatever
For clarification:
Is this correct? And the relation would be: In other words: |
Prefixes like |
Is it currently just not necessary that dialects load other dialects using |
correct. |
correct. I'd like to change this but this is sth for another PR. |
So right now, you can load a plugin via CLI or via |
One more remark: In bootstrap mode
But this is again sth for another day. |
There was also a bug that the name was replaced.
Fixes:
For now, the
XXX
within.import XXX
must be a single name in your search pathsThere were multiple reads of some files that sometimes caused funny behavior.
You can now load a plugin using
.plugin XXX;
in your.thorin
file.Changes
Driver
.fs::path
- includingLoc
.plugin
instead ofdialect
const Def*
->Ref
assert_emplace(container, val)
to assert that an insertion actually took placelookup(map, key)
that returns a pointer to value if found ornullptr
otherwise.Remarks
Although we can define now all kind things in our
imports
, I'm reluctant to actually use this feature because right now everything lives in a global namespace. We probably want to have sth smarter.