Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: PEP 625 compliance #31

Merged
merged 2 commits into from
Nov 21, 2024
Merged

feat: PEP 625 compliance #31

merged 2 commits into from
Nov 21, 2024

Conversation

bitwise-constructs
Copy link
Contributor

@bitwise-constructs bitwise-constructs commented Nov 21, 2024 •
edited
Loading

What I did

Upgrade setuptools to version that supports proper PEP 625 normalization

How I did it

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@bitwise-constructs
Copy link
Contributor Author

NetworkManager isn't adding fantom with the new sdist name, need to fix in core

@bitwise-constructs
Copy link
Contributor Author

disregard last comment, this is fixed by upgrading setuptools, not changing name in setup()

@bitwise-constructs bitwise-constructs merged commit 4070445 into ApeWorX:main Nov 21, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antazoey antazoey antazoey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bitwise-constructs @antazoey