Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: could not get transaction hash for sequencer transactions #40

Merged
merged 3 commits into from
Feb 7, 2025

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Feb 5, 2025

What I did

The transaction hash was missing for sequencer transactions.
Also, OP stack custom networks was under-documented.

How I did it

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

uri: https://rpc.frax.com
```

There are two main benefits of using Optimism as the base-class instead of Ethereum for networks using the OP stack:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fubuloubu What other benefits can we include in the plugin?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In terms of docs what we currently have, think we have that covered nicely

In terms of ideas, some ideas:

  • track L1 block confirmations
  • do native bridge actions (there are other bridge types):
    • L1 -> L2 deposits of supported tokens e.g. ETH
    • L2 -> L1 withdrawals (which take 7 days)
  • they also have some native "pre-compiles" that come out of the box w/ OP stack chains

Copy link
Contributor

@bitwise-constructs bitwise-constructs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Helpful documentation added to this too, lgtm

@antazoey antazoey merged commit 7520b53 into ApeWorX:main Feb 7, 2025
15 checks passed
@antazoey antazoey deleted the docs/op-stack branch February 7, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants