Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update lint #172

Merged
merged 8 commits into from
Nov 24, 2024
Merged

chore: update lint #172

merged 8 commits into from
Nov 24, 2024

Conversation

dtdang
Copy link
Contributor

@dtdang dtdang commented Nov 19, 2024

What I did

Upgrade lint and pre-commit since things were failing in the tests.

fixes: #

How I did it

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@dtdang dtdang enabled auto-merge (squash) November 19, 2024 23:34
setup.py Outdated Show resolved Hide resolved
@antazoey
Copy link
Member

antazoey commented Nov 20, 2024

mdformat-pyproject has been updated (0.0.2); you can no update mdformat if you want.
(see ApeWorX/ape#2381)

antazoey
antazoey previously approved these changes Nov 21, 2024
@antazoey
Copy link
Member

@dtdang Don't forget to also run mdformat

fubuloubu
fubuloubu previously approved these changes Nov 21, 2024
@antazoey
Copy link
Member

antazoey commented Nov 21, 2024

The latest releases of taskiq may have broken silverback.
https://github.com/taskiq-python/taskiq/pull/381/files

fubuloubu
fubuloubu previously approved these changes Nov 24, 2024
fubuloubu
fubuloubu previously approved these changes Nov 24, 2024
Copy link
Member

@fubuloubu fubuloubu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA: Double check these upgrades (silverback run and silverback worker commands)

@fubuloubu fubuloubu merged commit 282e910 into ApeWorX:main Nov 24, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants