fix(cluster): cluster updates #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also removed "immutability" design from previously
fubuloubu
force-pushed
the
fix/cluster-updates
branch
from
841eb75 to
f4a1380
Compare
fubuloubu
commented
Feb 5, 2025
fubuloubu
force-pushed
the
fix/cluster-updates
branch
from
9c75f89 to
346d252
Compare
fubuloubu
force-pushed
the
fix/cluster-updates
branch
from
43518d1 to
b9d3b02
Compare
johnson2427
approved these changes
Feb 6, 2025
There was a problem hiding this comment.
Only thing here, for getting errors, we have not implemented that in the API. Implementing that requires some thought too. Other than attempting to parse all logs for ERROR, we'd have to store error logs in the database if we wanted that to be cleaner. Not sure what to do here. Do we include the get error method here? Or do we remove it from the CLI for now and leave a TODO?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
fixes: #
How I did it
How to verify it
Checklist
- [ ] New test cases have been added and are passing- [ ] Documentation has been updated