-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: error checking type for "subscripted generics" #77
Conversation
# NOTE: Interesting side effect is that `int` outside the INT96 range parse as `Decimal` | ||
# This is okay, preferable actually, because it means we can store ints outside that range |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mikeshultz this is actually kinda interesting, it will "auto-parse" values outside the INT96 range as Decimal, which can actually be (less efficiently) encoded by Parquet, avoiding raising a bug about it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In [14]: Datapoints(root={"return_value": 1324})
Out[14]: Datapoints(root={'return_value': ScalarDatapoint(type='scalar', data=1324)})
In [15]: Datapoints(root={"return_value": 2**291})
Out[15]: Datapoints(root={'return_value': ScalarDatapoint(type='scalar', data=Decimal('3978585891278293137243057985174566720803649206378781739523711815145275976100267004264448'))})
a50305f
to
c48ba5c
Compare
c48ba5c
to
b8ca476
Compare
What I did
Fixes the error:
Checklist