fix: Replace shr with sar for integer types
#35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit replaces `shr` with `sar` in the assembly code of `TickMath.sol`, specifically in commands dealing with integer types. Additionally, it includes an update to the interaction with the variable `tick256` - dropping the `signextend` function and just referencing `tick`. The changes also affect gas snapshots, though it is not the primary purpose of these modifications.
|
@gnarlycow Please merge the bug fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit replaces
shrwithsarin the assembly code ofTickMath.sol, specifically in commands dealing with integer types. Additionally, it includes an update to the interaction with the variabletick256- dropping thesignextendfunction and just referencingtick. The changes also affect gas snapshots, though it is not the primary purpose of these modifications.