Use Shouldly in all test projects except Polly.Specs #2458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
De-centralise the FluentAssertions references and move them to each project individually to aid removing it project-by-project to switch over to Shouldly.
Use Shouldy instead of FluentAssertions in Polly.Testing.Tests.
Use Shouldy instead of FluentAssertions in Polly.RateLimiting.Tests.
Use Shouldy instead of FluentAssertions in Polly.Extensions.Tests.
Use Shouldy instead of FluentAssertions in Polly.Core.Tests.
martincostello
added
CI/build
dependencies
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2458 +/- ##
=======================================
Coverage 85.36% 85.36%
=======================================
Files 312 312
Lines 7464 7464
Branches 1121 1121
=======================================
Hits 6372 6372
Misses 907 907
Partials 185 185
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Swap for readability/correctness.
Use the `ShouldBeInOrder()` assertion method.
Use `ShouldBeEmpty()` instead of asserting a count of zero.
Fix undetected mutant by using a more strict assertion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate all test projects, except Polly.Specs, from using FluentAssertions to use Shouldly instead.
Contributes to #2450.