feat: support editor to show workspace view overview #4629
Conversation
Jayaprakash-dev
force-pushed
the
feat_workspace_view_overview
branch
3 times, most recently
from
238af72
to
eadcdc2
Compare
Jayaprakash-dev
force-pushed
the
feat_workspace_view_overview
branch
from
5a203ce
to
663682a
Compare
|
|
||
| typedef ChildViewsUpdateNotifier = void Function(ChildViewUpdatePB); | ||
|
|
||
| class WorkspaceOverviewListener { |
There was a problem hiding this comment.
What is the purpose of this class? If you want to receive updates for the current view and its child views, using ViewListener is sufficient in this case.
There was a problem hiding this comment.
@LucasXu0, The ViewListener class currently only monitors updates from its immediate view and its direct child views(i.e. first level child views). If ViewListener is used in the overview block, then the overview widget component lacks the functionality to listen for updates beyond the first level of child views. However, the WorkspaceOverviewListener class addresses this gap by enabling monitoring of changes in both its own view and all levels of child views in the hierarchy.
|
|
||
| String get viewId => context.read<DocumentBloc>().view.id; | ||
|
|
||
| final ValueNotifier<bool> _isExpandedNotifier = ValueNotifier(true); |
There was a problem hiding this comment.
imo, the "expand" value should also be saved in the data because this value needs to be synchronized.
There was a problem hiding this comment.
@LucasXu0, Could you provide additional context regarding the specific 'data' you're referring to?
...lugins/document/presentation/editor_plugins/overview/workspace_overview_block_component.dart
Outdated
Show resolved
Hide resolved
...lugins/document/presentation/editor_plugins/overview/workspace_overview_block_component.dart
Show resolved
Hide resolved
...lugins/document/presentation/editor_plugins/overview/workspace_overview_block_component.dart
Outdated
Show resolved
Hide resolved
...lugins/document/presentation/editor_plugins/overview/workspace_overview_block_component.dart
Outdated
Show resolved
Hide resolved
|
Hey, @Jayaprakash-dev, fyi, the review isn't complete yet. I need to run it locally to test the functionality. |
Jayaprakash-dev
force-pushed
the
feat_workspace_view_overview
branch
2 times, most recently
from
09b1330
to
6d1d9d8
Compare
…ture in a concise view
Jayaprakash-dev
force-pushed
the
feat_workspace_view_overview
branch
from
6d1d9d8
to
a09cfd0
Compare
|
I still want this feature, so if @Jayaprakash-dev is no longer available or interested, I'm willing to update the branch, or possibly give it a fresh start. |
I've addressed the issue #4282 by implementing the Workspace folder Overview feature, allowing users to create an outline for workspace folder/sub pages structures using the slash commands
/overviewor/workspace overview. This facilitates easy navigation in nested document structures.Screenshot and Demo
appflowy_workspace_overview_demo_comp.mov