Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyboard shortcut for 'Copy to clipboard' #6597

Closed

Conversation

Xeoneid
Copy link

@Xeoneid Xeoneid commented Oct 22, 2024

Fixes #6587


For more details, open the Copilot Workspace session.

@CLAassistant
Copy link

CLAassistant commented Oct 22, 2024

CLA assistant check
All committers have signed the CLA.

getDescription: () => 'Copy to clipboard',
command: 'ctrl+shift+c',
handler: (editorState) {
// Implement the handler for the 'Copy to clipboard' functionality
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The definition of customCopyToClipboardCommand makes no sense here. It's meant for documents, but I noticed you use it in the share menu.

},
actions: {
ActivateIntent: CallbackAction<Intent>(
onInvoke: (intent) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The onInvoke function and the handler are both null, with only 'placeholder' comments.

@appflowy
Copy link
Contributor

@Xeoneid I will close this PR due to prolonged inactivity. Feel free to reopen it anytime.

@appflowy appflowy closed this Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] Keyboard shortcut for Copy to clipboard
4 participants