Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change code order in some of the AppCoinsTimeLock functions and AppCoinsCreditBalance functions to implement check effect interaction pattern.
Motivation and Context
It is a best practice in Solidity to implement Check effect interaction pattern to prevent re-entry attacks.
Although the use of external contracts in this project is restricted to contracts produced within the project, it is a best practice to implement Check effect interaction pattern.
How Has This Been Tested?
Using the current unit tests
Screenshots (if appropriate):
Checklist:
dev
and targetsdev