Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/check effects interaction #120

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

tcrosado
Copy link
Contributor

@tcrosado tcrosado commented Feb 4, 2019

Description

Change code order in some of the AppCoinsTimeLock functions and AppCoinsCreditBalance functions to implement check effect interaction pattern.

Motivation and Context

It is a best practice in Solidity to implement Check effect interaction pattern to prevent re-entry attacks.

Although the use of external contracts in this project is restricted to contracts produced within the project, it is a best practice to implement Check effect interaction pattern.

How Has This Been Tested?

Using the current unit tests

Screenshots (if appropriate):

Checklist:

  • You have followed our contributing guidelines
  • double-check your branch is based on dev and targets dev
  • Pull request has tests (at least 80% coverage)
  • Code is well-commented, linted and follows project conventions
  • Documentation is updated (if necessary)
  • Description explains the issue/use-case resolved and auto-closes related issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants