Fix tests

Signed-off-by: Prabhu Subramanian <[email protected]>
AppThreat · Jan 17, 2024 · ff2b189 · ff2b189
1 parent 677088b
commit ff2b189
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/...nds/javasrc2cpg/src/test/scala/io/appthreat/javasrc2cpg/querying/TypeInferenceTests.scala b/...nds/javasrc2cpg/src/test/scala/io/appthreat/javasrc2cpg/querying/TypeInferenceTests.scala
@@ -363,8 +363,8 @@ class JavaTypeRecoveryPassTests extends JavaSrcCode2CpgFixture(enableTypeRecover
 
     "hint that `transaction` may be of the null type" in {
       val Some(transaction) = cpg.identifier("transaction").headOption: @unchecked
+        transaction.dynamicTypeHintFullName.contains("null")
       transaction.typeFullName shouldBe "org.hibernate.Transaction"
-      transaction.dynamicTypeHintFullName.contains("null")
     }
   }
 

diff --git a/...orm/frontends/x2cpg/src/main/scala/io/appthreat/x2cpg/passes/frontend/XTypeRecovery.scala b/...orm/frontends/x2cpg/src/main/scala/io/appthreat/x2cpg/passes/frontend/XTypeRecovery.scala
@@ -1239,7 +1239,7 @@ abstract class RecoverForXCompilationUnit[CompilationUnitType <: AstNode](
         if types.size == 1 then
             builder.setNodeProperty(n, PropertyNames.TYPE_FULL_NAME, types.head)
             builder.setNodeProperty(n, PropertyNames.DYNAMIC_TYPE_HINT_FULL_NAME, Seq.empty)
-        else if types.size == 2 then
+        else if types.size == 2 && types.last.nonEmpty && types.last != "null" then
             builder.setNodeProperty(n, PropertyNames.TYPE_FULL_NAME, types.last)
             builder.setNodeProperty(n, PropertyNames.DYNAMIC_TYPE_HINT_FULL_NAME, Seq(types.head))
         else builder.setNodeProperty(n, PropertyNames.DYNAMIC_TYPE_HINT_FULL_NAME, types)