Fix --bom-profile bugs. #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Caroline Russell <[email protected]>
Signed-off-by: Caroline Russell <[email protected]>
Signed-off-by: Caroline Russell <[email protected]>
prabhu
approved these changes
Nov 26, 2024
Signed-off-by: Caroline Russell <[email protected]>
Signed-off-by: Caroline Russell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes various bugs in --bom-profile, namely that the argument was not set in cli.py and reliance on bom-ref to identify unique and common components. Also offers a simpler HTML report. Please note the component list is now being deduped as limiting to 2-3 fields for comparison results in multiple components which are indistinguishable from each other - e.g. when multiple versions of the same component are present in the bom but we are excluding the version from comparison.