Implement ElapsedTimeTracker to support AEKeyType AmountPerUnit scaling #8170
Conversation
|
Updated to newest commit |
|
Please run the |
Hi 62832, thanks for reminding me. I have applied the spotless format check and passed the checks. |
| } | ||
|
|
||
| public long getStartItemCount() { | ||
| return this.startItemCount; | ||
| return Math.round(((float) this.startItemCount) / AEKEY_SCALE_FACTOR); |
There was a problem hiding this comment.
Why not just use integer division here?
There was a problem hiding this comment.
Why not just use integer division here?
Integer Division equals Math.floor, making the 99/10 = 9 instead of 10 in this case.
I want to round to make it more precise in displaying, for showing progress, the trade-off is performance.
There was a problem hiding this comment.
If you want to simulate math.round() with integer division you can add half of the AE_SCALE_FACTOR before dividing, right?
There was a problem hiding this comment.
If you want to simulate math.round() with integer division you can add half of the AE_SCALE_FACTOR before dividing, right?
You are right. I have updated.
|
This doesn't actually work for me , it continually shows "0 crafted" when crafting water in the test world. |
|
I am changing this to sync the percentage to clients and internally track the work by type...
|
|
Since you didn't enable the checkbox to allow comitters access, I'll have to open my own PR with the changes |
|
Opened #8266 with the changes |
Implement #7321, and replace #8045.
This is by adding internal scaling to keep the tracker as an integer.
Possible issue: broken changes due to NBT data in the disk may be invalid.