Do not allow items to be inserted into the Matter Condenser when the output slot is full

[62832]

Closes #8311.

[Mithi83]

I was tempted to tackle this bug too but ultimately didn't because this changes the semantics of the matter condenser a bit. The old implementation was something along the line of it being a fancy trash can which could potentially give you something in return if you can manage to pull it out fast enough. The emphasis was on trash can with a small perk, i.e. its main feature was to void items as fast as they could be put inside of it.

Your PR changes that to something like this: The matter condenser is primarily used for generating a resource (matter balls or singularities) from trash. This can now stall if extraction is too slow to prevent the build up and this could propagate down the entire supply line and thus lead so some unintended side effects.

I've not taken a closer look at the code yet, but have you considered the cases that the matter condenser is set to trash can mode and may or may not have any storage? Will that stall eventually as well?

[62832]

I've not taken a closer look at the code yet, but have you considered the cases that the matter condenser is set to trash can mode and may or may not have any storage? Will that stall eventually as well?

If the Matter Condenser is set purely to its trashing mode then there's never an output to consider that would even stall; getOutput() always returns an empty ItemStack in that case and canAddOutput() always returns true as a result.