Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added golangci config to enable additional checks #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added golangci config to enable additional checks #14

wants to merge 1 commit into from

Conversation

SamiPussinen
Copy link

This PR adds our preferred config for the golanci.

@SamiPussinen SamiPussinen requested a review from antnsi June 27, 2018 14:47
@antnsi
Copy link
Contributor

antnsi commented Jun 27, 2018 •
edited
Loading

I guess it's not testing only commit diff? but then why it didn't find any issues..

@antnsi
Copy link
Contributor

antnsi commented Jun 28, 2018 •
edited
Loading

so let's add golangci-lint as a tool is same pr?

@jirfag
Copy link

jirfag commented Jun 28, 2018

hi, thank you for using golangci.com!
@antnsi it reports only about issues in commit diff, there is no way to comment issues not from the diff in GitHub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antnsi antnsi Awaiting requested review from antnsi

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SamiPussinen @antnsi @jirfag