Quote Replies: Fix script not functioning #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the record, my preference for not hiding the quote replies button on non-hovered activity items was partially so that this kind of thing would have been more obvious and would have been fixed weeks/months ago :D
Description
This fixes Quote Replies having been completely broken by small changes in the latest update to the activity items. (That I can tell, the extra div element in the dropdown serves no purpose and might have been a "mistake," but whatever :D)
This was not reported by anyone, but was just mentioned in the tags of a few posts! I had not noticed it. Please, anyone who is reading this: if you find that XKit Rewritten is broken by an update, tell us about it!
edit: resolves #1126
Testing steps
Confirm that Quote Replies buttons appear next to mentions in the activity dropdown menu and on the activity page,