Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AccessKit: Make links blue consistently #1143

Merged

Conversation

marcustyphoon
Copy link
Collaborator

@marcustyphoon marcustyphoon commented Jul 14, 2023

Description

This fixes instances where AccessKit's "Make links in posts blue" feature does not work (see linked issue), as well as choosing a color from the palette that is a) more often actually blue and b) sort of arguably more correct... on a larger number of palettes? (see comments below)

Resolves #1135.

Testing steps

Test the relevant AccessKit option on:

links that go to anywhere on a Tumblr domain, mentions... or links in posts when they're reblogged on the staff blog or Matt's blog

Test the relevant AccessKit option on various palettes; see the comments below.

@marcustyphoon
Copy link
Collaborator Author

As an aside: should this use accent or blue?

Palettes where it doesn't really matter:

  • true blue
  • dark mode
  • low contrast
  • cybernetic
  • pride
  • ghost

Palettes where I prefer blue:

  • cement
  • canary
  • vampire
  • pumpkin
  • ["decision 2016" from palettes for tumblr]

Palettes where I prefer accent:

  • snow bright
  • goth rave

To play with this, I used

article ${keyToCss('textBlock')} a[target="_blank"] {
  color: rgba(var(--accent));
}
article ${keyToCss('textBlock')}:first-child a[target="_blank"] {
  color: rgba(var(--blue));
}

@marcustyphoon
Copy link
Collaborator Author

marcustyphoon commented Jul 14, 2023

Notably, blue is used to highlight tabs in the notes view container, while accent is used to highlight comments that are by the original post author. Screenshot taken with the mention link highlighted blue.

@marcustyphoon

This comment was marked as off-topic.

@marcustyphoon marcustyphoon merged commit 4eea57f into AprilSylph:master Dec 7, 2023
2 checks passed
@marcustyphoon marcustyphoon deleted the blue-links-consistent branch December 7, 2023 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AccessKit: "Make links in posts blue" option is broken
2 participants