-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create dev tools and css map tool #1216
base: master
Are you sure you want to change the base?
Conversation
this is just my userscript
third option plz ❤️ |
Aw man. I had this cute idea to add attribute change observation as an option for registering page modification handlers with our regular util, but that would probably only be a good idea if one could disable the mutation observer while we set classnames on stuff (and enable it again afterward) so that you don't get a cascading waterfall of *besides that my weird alt text reminder PR would lose a few lines of code maybe |
Description
I have, like, zero opinion about what any of this is called, what format it uses, whatever.
The notable choice we have here is whether to:
pageModifications
, which has slightly less performance impact but will fail on elements that Tumblr updates theclassList
of (like when you switch dashboard tabs and the tab elements become highlighted/unhighlightedattributeFilter: ['class']
and just querySelector the whole damn document, which is technically slower (though I run this as a userscript 100% of the time; the performance hit is not noticable)attributeFilter: ['class']
and parse themutationRecord
(fancy~)Testing steps