AccessKit Disable GIFs: Improvements to recommended blog cards #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcustyphoon
changed the title
marcustyphoon
changed the title
marcustyphoon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At present, AccessKit does pause GIFs in recommended blog carousels, but a) they don't unpause on hover, and b) there are sometimes two overlapping gif labels visible due to the way Tumblr makes a blurred background copy of non-square images*. This hides the duplicate labels and makes the recommended blog cards into hover-to-unpause targets.
*I can't get a screenshot of this because by the time I reverted this PR, I no longer had any of these. Developing modifications for a nondeterministic feature is annoying.
Testing steps