Fix Quick Reblog double reblogs after extension update/restart (alternative 4) #1601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #1597. See issue for background.
A fairly elegant, self-contained way to prevent this problem is to remove the previous version of the event listener. Fortunately, javascript supplies us with a way to do this: the
AbortController. This is compatible with #1538, as it requires no communication between the main world script(s) and content script.This won't apply to the instance where a version of the code without this PR merged is replaced by one with it, so this also changes the custom event names to handle that case.
Testing steps