AccessKit Disable GIFs: Refactor async callbacks #1683
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Annoyingly, this seems to just sometimes fail in Firefox in my testing. |
|
Ah, figured out why and noted it in an MDN issue: mdn/content#38034 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disable GIFs currently sets some
onloadcallbacks to wait for image element sources to be loaded. This replaces them with the decode() HTMLImageElement instance method that I found while looking through MDN for something different-but-related, removing some nesting. Conveniently, this doesn't require a conditional for whether the image is already loaded (try$0.decode().then(() => console.log('done'))on an already-loaded image)."Hide whitespace" is recommended.
Testing steps