imp - Navigation sounds should not play twice

--- When the terminal reader is busy with TermReader.IsReaderBusy being true, we shouldn't attempt to play the audio cue from ReadKey(). --- Type: imp Breaking: False Doc Required: False Backport Required: False Part: 1/1
Aptivi · Feb 16, 2025 · 7a9c86d · 7a9c86d
1 parent 55a7732
commit 7a9c86d
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 7 deletions.
diff --git a/private/Nitrocid.Tests/Nitrocid.Tests.csproj b/private/Nitrocid.Tests/Nitrocid.Tests.csproj
@@ -61,7 +61,7 @@
 
   <ItemGroup>
     <PackageReference Include="Shouldly" Version="4.3.0" />
-    <PackageReference Include="Terminaux" Version="6.1.5" />
+    <PackageReference Include="Terminaux" Version="6.1.6" />
   </ItemGroup>
 
   <ItemGroup>

diff --git a/public/Nitrocid.Addons/Nitrocid.Extras.Images.Icons/Nitrocid.Extras.Images.Icons.csproj b/public/Nitrocid.Addons/Nitrocid.Extras.Images.Icons/Nitrocid.Extras.Images.Icons.csproj
@@ -31,7 +31,7 @@
   <!-- Extras.Images.Icons addon Platform Information End -->
 
   <ItemGroup>
-    <PackageReference Include="Terminaux.Images.Icons" Version="6.1.5" />
+    <PackageReference Include="Terminaux.Images.Icons" Version="6.1.6" />
   </ItemGroup>
 
 </Project>
diff --git a/public/Nitrocid.Analyzers/Nitrocid.StandaloneAnalyzer/Nitrocid.StandaloneAnalyzer.csproj b/public/Nitrocid.Analyzers/Nitrocid.StandaloneAnalyzer/Nitrocid.StandaloneAnalyzer.csproj
@@ -32,7 +32,7 @@
     <PackageReference Include="Microsoft.CodeAnalysis.Analyzers" Version="3.11.0" PrivateAssets="all" />
     <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="[4.8.0]" />
     <PackageReference Include="Microsoft.CodeAnalysis.Workspaces.MSBuild" Version="[4.8.0]" />
-    <PackageReference Include="Terminaux" Version="6.1.5" />
+    <PackageReference Include="Terminaux" Version="6.1.6" />
   </ItemGroup>
 
   <Import Project="..\Nitrocid.Analyzers.Common\Nitrocid.Analyzers.Common.projitems" Label="Shared" />

diff --git a/public/Nitrocid.Locales/Nitrocid.Locales.csproj b/public/Nitrocid.Locales/Nitrocid.Locales.csproj
@@ -70,7 +70,7 @@
     <PackageReference Include="Microsoft.CodeAnalysis.Analyzers" Version="3.11.0" PrivateAssets="all" />
     <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="[4.8.0]" />
     <PackageReference Include="Microsoft.CodeAnalysis.Workspaces.MSBuild" Version="[4.8.0]" />
-    <PackageReference Include="Terminaux" Version="6.1.5" />
+    <PackageReference Include="Terminaux" Version="6.1.6" />
   </ItemGroup>
 
   <ItemGroup>

diff --git a/public/Nitrocid/Drivers/Console/BaseConsoleDriver.cs b/public/Nitrocid/Drivers/Console/BaseConsoleDriver.cs
@@ -39,6 +39,7 @@
 using Nitrocid.ConsoleBase.Colors;
 using Nitrocid.Kernel.Configuration;
 using Nitrocid.Misc.Audio;
+using Terminaux.Reader;
 
 namespace Nitrocid.Drivers.Console
 {
@@ -293,7 +294,7 @@ public virtual ConsoleKeyInfo ReadKey(bool intercept = false)
         {
             var keyInfo = SystemConsole.ReadKey(intercept);
             _moved = true;
-            if (Config.MainConfig.EnableNavigationSounds)
+            if (Config.MainConfig.EnableNavigationSounds && !TermReader.IsReaderBusy)
                 AudioCuesTools.PlayAudioCue(AudioCueType.KeyboardCueType);
             return keyInfo;
         }

diff --git a/public/Nitrocid/Nitrocid.csproj b/public/Nitrocid/Nitrocid.csproj
@@ -51,8 +51,8 @@
 
   <!-- KS Non-private Dependencies Information -->
   <ItemGroup>
-    <PackageReference Include="Terminaux" Version="6.1.5" PrivateAssets="contentfiles;analyzers;build;runtime;native" />
-    <PackageReference Include="Terminaux.Images" Version="6.1.5" PrivateAssets="contentfiles;analyzers;build;runtime;native" />
+    <PackageReference Include="Terminaux" Version="6.1.6" PrivateAssets="contentfiles;analyzers;build;runtime;native" />
+    <PackageReference Include="Terminaux.Images" Version="6.1.6" PrivateAssets="contentfiles;analyzers;build;runtime;native" />
     <PackageReference Include="Textify.Offline" Version="2.9.0" PrivateAssets="contentfiles;analyzers;build;runtime">
       <Aliases>global,TextifyDep</Aliases>
     </PackageReference>