fix - Fixed showcase out of bounds

--- Showcase in some charts goes out of bounds in certain conditions, so we've decided to fix it. --- Type: fix Breaking: False Doc Required: False Backport Required: False Part: 1/1
Aptivi · Jan 13, 2025 · bdb26c8 · bdb26c8
1 parent 57a11eb
commit bdb26c8
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 4 deletions.
diff --git a/private/Terminaux.Console/Fixtures/FixtureManager.cs b/private/Terminaux.Console/Fixtures/FixtureManager.cs
@@ -178,7 +178,6 @@ internal static class FixtureManager
             new TestSyntaxText(),
             new TestLineChart(),
             new TestWinsLosses(),
-            new TestAreaChart(),
 
             // Input
             new TestInputSelection(),

diff --git a/public/Terminaux/Writer/CyclicWriters/BreakdownChart.cs b/public/Terminaux/Writer/CyclicWriters/BreakdownChart.cs
@@ -163,7 +163,7 @@ internal static string RenderBreakdownChart(ChartElement[] elements, int Interio
                     if (showcase && i < shownElements.Length)
                     {
                         var element = shownElements[i];
-                        int nameWidth = ConsoleChar.EstimateCellWidth(element.Name);
+                        int nameWidth = ConsoleChar.EstimateCellWidth(element.Name.Truncate(nameLength - 4 - $"{maxValue}".Length));
                         int spaces = showcaseLength - (" ■ ".Length + nameWidth + 2 + $"{element.Value}".Length);
                         spaces = spaces < 0 ? 0 : spaces;
                         breakdownChart.Append(

diff --git a/public/Terminaux/Writer/CyclicWriters/LineChart.cs b/public/Terminaux/Writer/CyclicWriters/LineChart.cs
@@ -154,7 +154,7 @@ internal static string RenderLineChart(ChartElement[] elements, int InteriorWidt
                 if (showcase && i < shownElements.Length)
                 {
                     var element = shownElements[i];
-                    int nameWidth = ConsoleChar.EstimateCellWidth(element.Name);
+                    int nameWidth = ConsoleChar.EstimateCellWidth(element.Name.Truncate(nameLength - 4 - $"{maxValue}".Length));
                     int spaces = showcaseLength - (" ■ ".Length + nameWidth + 2 + $"{element.Value}".Length);
                     spaces = spaces < 0 ? 0 : spaces;
                     lineChart.Append(

diff --git a/public/Terminaux/Writer/CyclicWriters/StickChart.cs b/public/Terminaux/Writer/CyclicWriters/StickChart.cs
@@ -141,7 +141,7 @@ internal static string RenderStickChart(ChartElement[] elements, int InteriorWid
                 if (showcase && i < shownElements.Length)
                 {
                     var element = shownElements[i];
-                    int nameWidth = ConsoleChar.EstimateCellWidth(element.Name);
+                    int nameWidth = ConsoleChar.EstimateCellWidth(element.Name.Truncate(nameLength - 4 - $"{maxValue}".Length));
                     int spaces = showcaseLength - (" ■ ".Length + nameWidth + 2 + $"{element.Value}".Length);
                     spaces = spaces < 0 ? 0 : spaces;
                     stickChart.Append(