Skip to content

Commit

Permalink
Fix failure for versionable items
Browse files Browse the repository at this point in the history
Action was previously querying on the context item's id, which only worked if the item was non-versionable or if the item's first generation was added to a package.

Action now queries for package elements where the element_id matches the id of any of the context item's versions.
  • Loading branch information
EliJDonahue committed Oct 25, 2016
1 parent 34c22c1 commit eb24d94
Show file tree
Hide file tree
Showing 18 changed files with 354 additions and 70 deletions.
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<AML>
<Item type="Action" id="7E41725E177B4C04ADF87906B033900F" action="add">
<item_query>&lt;Item type="{@type}" id="{@id}" levels= "1" action="get" /&gt;</item_query>
<item_query>&lt;Item type="{@type}" id="{@id}" levels= "1" action="get" select="config_id" /&gt;</item_query>
<label xml:lang="en">Find Parent Package</label>
<location>client</location>
<method keyed_name="labs_FindParentPackage" type="Method">
Expand Down
66 changes: 0 additions & 66 deletions Import/FindParentPackage/Import/Fixes/AddActionToItemTypes.xml

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
<AML>
<Item type="Item Action" id="0794B7A22B5B4BC1A398A2818038223E" action="add">
<related_id keyed_name="labs_FindParentPackage" type="Action">
<Item type="Action" id="7E41725E177B4C04ADF87906B033900F" action="add">
<item_query>&lt;Item type="{@type}" id="{@id}" levels= "1" action="get" select="config_id" /&gt;</item_query>
<label xml:lang="en">Find Parent Package</label>
<location>client</location>
<method keyed_name="labs_FindParentPackage" type="Method">
<Item type="Method" action="get" select="id">
<name>labs_FindParentPackage</name>
</Item>
</method>
<target>none</target>
<type>item</type>
<name>labs_FindParentPackage</name>
</Item>
</related_id>
<sort_order>128</sort_order>
<source_id keyed_name="CommandBarSection" type="ItemType" name="CommandBarSection">6DF95CF17D824F5DAC6A996FFC34D5F8</source_id>
</Item>
</AML>
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
<AML>
<Item type="Item Action" id="34FFDB0D63FF4399BC83E1CD8643F840" action="add">
<related_id keyed_name="labs_FindParentPackage" type="Action">
<Item type="Action" id="7E41725E177B4C04ADF87906B033900F" action="add">
<item_query>&lt;Item type="{@type}" id="{@id}" levels= "1" action="get" select="config_id" /&gt;</item_query>
<label xml:lang="en">Find Parent Package</label>
<location>client</location>
<method keyed_name="labs_FindParentPackage" type="Method">
<Item type="Method" action="get" select="id">
<name>labs_FindParentPackage</name>
</Item>
</method>
<target>none</target>
<type>item</type>
<name>labs_FindParentPackage</name>
</Item>
</related_id>
<sort_order>128</sort_order>
<source_id keyed_name="Form" type="ItemType" name="Form">47573682FB7549F59ADECD4BFE04F1DE</source_id>
</Item>
</AML>
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
<AML>
<Item type="Item Action" id="39B5547A185B42359F80181F475B5262" action="add">
<related_id keyed_name="labs_FindParentPackage" type="Action">
<Item type="Action" id="7E41725E177B4C04ADF87906B033900F" action="add">
<item_query>&lt;Item type="{@type}" id="{@id}" levels= "1" action="get" select="config_id" /&gt;</item_query>
<label xml:lang="en">Find Parent Package</label>
<location>client</location>
<method keyed_name="labs_FindParentPackage" type="Method">
<Item type="Method" action="get" select="id">
<name>labs_FindParentPackage</name>
</Item>
</method>
<target>none</target>
<type>item</type>
<name>labs_FindParentPackage</name>
</Item>
</related_id>
<sort_order>128</sort_order>
<source_id keyed_name="Life Cycle Map" type="ItemType" name="Life Cycle Map">AC32527D85604A4D9FC9107C516AEF47</source_id>
</Item>
</AML>
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
<AML>
<Item type="Item Action" id="43343E4EACCE4F37A1C4A399DE7CF6ED" action="add">
<related_id keyed_name="labs_FindParentPackage" type="Action">
<Item type="Action" id="7E41725E177B4C04ADF87906B033900F" action="add">
<item_query>&lt;Item type="{@type}" id="{@id}" levels= "1" action="get" select="config_id" /&gt;</item_query>
<label xml:lang="en">Find Parent Package</label>
<location>client</location>
<method keyed_name="labs_FindParentPackage" type="Method">
<Item type="Method" action="get" select="id">
<name>labs_FindParentPackage</name>
</Item>
</method>
<target>none</target>
<type>item</type>
<name>labs_FindParentPackage</name>
</Item>
</related_id>
<sort_order>256</sort_order>
<source_id keyed_name="SQL" type="ItemType" name="SQL">FC3E32F18F804FD9BE4B175973D29112</source_id>
</Item>
</AML>
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
<AML>
<Item type="Item Action" id="503A0444376F439CBF2BA8C66969CCDA" action="add">
<related_id keyed_name="labs_FindParentPackage" type="Action">
<Item type="Action" id="7E41725E177B4C04ADF87906B033900F" action="add">
<item_query>&lt;Item type="{@type}" id="{@id}" levels= "1" action="get" select="config_id" /&gt;</item_query>
<label xml:lang="en">Find Parent Package</label>
<location>client</location>
<method keyed_name="labs_FindParentPackage" type="Method">
<Item type="Method" action="get" select="id">
<name>labs_FindParentPackage</name>
</Item>
</method>
<target>none</target>
<type>item</type>
<name>labs_FindParentPackage</name>
</Item>
</related_id>
<sort_order>128</sort_order>
<source_id keyed_name="Permission" type="ItemType" name="Permission">C6A89FDE1294451497801DF78341B473</source_id>
</Item>
</AML>
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
<AML>
<Item type="Item Action" id="57CDD4C5595C49469F629CCDF5B42CB7" action="add">
<related_id keyed_name="labs_FindParentPackage" type="Action">
<Item type="Action" id="7E41725E177B4C04ADF87906B033900F" action="add">
<item_query>&lt;Item type="{@type}" id="{@id}" levels= "1" action="get" select="config_id" /&gt;</item_query>
<label xml:lang="en">Find Parent Package</label>
<location>client</location>
<method keyed_name="labs_FindParentPackage" type="Method">
<Item type="Method" action="get" select="id">
<name>labs_FindParentPackage</name>
</Item>
</method>
<target>none</target>
<type>item</type>
<name>labs_FindParentPackage</name>
</Item>
</related_id>
<sort_order>128</sort_order>
<source_id keyed_name="Report" type="ItemType" name="Report">F0834BBA6FB64394B78DF5BB725532DD</source_id>
</Item>
</AML>
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
<AML>
<Item type="Item Action" id="5F3E77988CB54E33B7DB3831982BC47E" action="add">
<related_id keyed_name="labs_FindParentPackage" type="Action">
<Item type="Action" id="7E41725E177B4C04ADF87906B033900F" action="add">
<item_query>&lt;Item type="{@type}" id="{@id}" levels= "1" action="get" select="config_id" /&gt;</item_query>
<label xml:lang="en">Find Parent Package</label>
<location>client</location>
<method keyed_name="labs_FindParentPackage" type="Method">
<Item type="Method" action="get" select="id">
<name>labs_FindParentPackage</name>
</Item>
</method>
<target>none</target>
<type>item</type>
<name>labs_FindParentPackage</name>
</Item>
</related_id>
<sort_order>128</sort_order>
<source_id keyed_name="Grid" type="ItemType" name="Grid">8EABD91B465443F0A4995418F483DC51</source_id>
</Item>
</AML>
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
<AML>
<Item type="Item Action" id="683A45CA661E40FC90BBF0108E615557" action="add">
<related_id keyed_name="labs_FindParentPackage" type="Action">
<Item type="Action" id="7E41725E177B4C04ADF87906B033900F" action="add">
<item_query>&lt;Item type="{@type}" id="{@id}" levels= "1" action="get" select="config_id" /&gt;</item_query>
<label xml:lang="en">Find Parent Package</label>
<location>client</location>
<method keyed_name="labs_FindParentPackage" type="Method">
<Item type="Method" action="get" select="id">
<name>labs_FindParentPackage</name>
</Item>
</method>
<target>none</target>
<type>item</type>
<name>labs_FindParentPackage</name>
</Item>
</related_id>
<sort_order>128</sort_order>
<source_id keyed_name="Workflow Map" type="ItemType" name="Workflow Map">B19D349CC6FC44BC97D50A6D70AE79CB</source_id>
</Item>
</AML>
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
<AML>
<Item type="Item Action" id="88C421C32FA144D4A69E40EA64C1B46C" action="add">
<related_id keyed_name="labs_FindParentPackage" type="Action">
<Item type="Action" id="7E41725E177B4C04ADF87906B033900F" action="add">
<item_query>&lt;Item type="{@type}" id="{@id}" levels= "1" action="get" select="config_id" /&gt;</item_query>
<label xml:lang="en">Find Parent Package</label>
<location>client</location>
<method keyed_name="labs_FindParentPackage" type="Method">
<Item type="Method" action="get" select="id">
<name>labs_FindParentPackage</name>
</Item>
</method>
<target>none</target>
<type>item</type>
<name>labs_FindParentPackage</name>
</Item>
</related_id>
<sort_order>128</sort_order>
<source_id keyed_name="RelationshipType" type="ItemType" name="RelationshipType">471932C33B604C3099070F4106EE5024</source_id>
</Item>
</AML>
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
<AML>
<Item type="Item Action" id="8B2264C6885B40D6A1DFEB5A660FF41B" action="add">
<related_id keyed_name="labs_FindParentPackage" type="Action">
<Item type="Action" id="7E41725E177B4C04ADF87906B033900F" action="add">
<item_query>&lt;Item type="{@type}" id="{@id}" levels= "1" action="get" select="config_id" /&gt;</item_query>
<label xml:lang="en">Find Parent Package</label>
<location>client</location>
<method keyed_name="labs_FindParentPackage" type="Method">
<Item type="Method" action="get" select="id">
<name>labs_FindParentPackage</name>
</Item>
</method>
<target>none</target>
<type>item</type>
<name>labs_FindParentPackage</name>
</Item>
</related_id>
<sort_order>128</sort_order>
<source_id keyed_name="Action" type="ItemType" name="Action">483228BE6B9A4C0E99ACD55FDF328DEC</source_id>
</Item>
</AML>
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
<AML>
<Item type="Item Action" id="A0D2674F0B154C71B268BC51007BA2C0" action="add">
<related_id keyed_name="labs_FindParentPackage" type="Action">
<Item type="Action" id="7E41725E177B4C04ADF87906B033900F" action="add">
<item_query>&lt;Item type="{@type}" id="{@id}" levels= "1" action="get" select="config_id" /&gt;</item_query>
<label xml:lang="en">Find Parent Package</label>
<location>client</location>
<method keyed_name="labs_FindParentPackage" type="Method">
<Item type="Method" action="get" select="id">
<name>labs_FindParentPackage</name>
</Item>
</method>
<target>none</target>
<type>item</type>
<name>labs_FindParentPackage</name>
</Item>
</related_id>
<sort_order>256</sort_order>
<source_id keyed_name="Method" type="ItemType" name="Method">87879A09B8044DE380D59DF22DE1867F</source_id>
</Item>
</AML>
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
<AML>
<Item type="Item Action" id="B4F57622960E428DA025B54C46505D28" action="add">
<related_id keyed_name="labs_FindParentPackage" type="Action">
<Item type="Action" id="7E41725E177B4C04ADF87906B033900F" action="add">
<item_query>&lt;Item type="{@type}" id="{@id}" levels= "1" action="get" select="config_id" /&gt;</item_query>
<label xml:lang="en">Find Parent Package</label>
<location>client</location>
<method keyed_name="labs_FindParentPackage" type="Method">
<Item type="Method" action="get" select="id">
<name>labs_FindParentPackage</name>
</Item>
</method>
<target>none</target>
<type>item</type>
<name>labs_FindParentPackage</name>
</Item>
</related_id>
<sort_order>128</sort_order>
<source_id keyed_name="Identity" type="ItemType" name="Identity">E582AB17663F4EF28460015B2BE9E094</source_id>
</Item>
</AML>
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
<AML>
<Item type="Item Action" id="D4C401695EE7429A845D7284AF21D96C" action="add">
<related_id keyed_name="labs_FindParentPackage" type="Action">
<Item type="Action" id="7E41725E177B4C04ADF87906B033900F" action="add">
<item_query>&lt;Item type="{@type}" id="{@id}" levels= "1" action="get" select="config_id" /&gt;</item_query>
<label xml:lang="en">Find Parent Package</label>
<location>client</location>
<method keyed_name="labs_FindParentPackage" type="Method">
<Item type="Method" action="get" select="id">
<name>labs_FindParentPackage</name>
</Item>
</method>
<target>none</target>
<type>item</type>
<name>labs_FindParentPackage</name>
</Item>
</related_id>
<sort_order>128</sort_order>
<source_id keyed_name="ItemType" type="ItemType" name="ItemType">450906E86E304F55A34B3C0D65C097EA</source_id>
</Item>
</AML>
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
<AML>
<Item type="Item Action" id="E73F5F3597534A829752428550F8B204" action="add">
<related_id keyed_name="labs_FindParentPackage" type="Action">
<Item type="Action" id="7E41725E177B4C04ADF87906B033900F" action="add">
<item_query>&lt;Item type="{@type}" id="{@id}" levels= "1" action="get" select="config_id" /&gt;</item_query>
<label xml:lang="en">Find Parent Package</label>
<location>client</location>
<method keyed_name="labs_FindParentPackage" type="Method">
<Item type="Method" action="get" select="id">
<name>labs_FindParentPackage</name>
</Item>
</method>
<target>none</target>
<type>item</type>
<name>labs_FindParentPackage</name>
</Item>
</related_id>
<sort_order>128</sort_order>
<source_id keyed_name="PresentationConfiguration" type="ItemType" name="PresentationConfiguration">80881F5852BC439E9F3CF0AEC03ABE2A</source_id>
</Item>
</AML>
Loading

0 comments on commit eb24d94

Please sign in to comment.