Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1753 add opens module to all scripts #1754

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

robfrank
Copy link
Collaborator

@robfrank robfrank commented Oct 14, 2024

What does this PR do?

Adds --opens-module to fix #1753 on all the scripts

Motivation

while on java 11 is not needed, it is needed on java 17

Related issues

A list of issues either fixed, containing architectural discussions, otherwise relevant
for this Pull Request.

Additional Notes

Anything else we should know when reviewing?

Checklist

  • I have run the build using mvn clean package command
  • My unit tests cover both failure and success scenarios

@robfrank robfrank requested review from lvca and gramian October 14, 2024 16:01
@robfrank robfrank added this to the 24.11.1 milestone Oct 14, 2024
@robfrank robfrank self-assigned this Oct 14, 2024
@robfrank robfrank added the bug Something isn't working label Oct 14, 2024
improve logging
improve readability on scripts
@robfrank robfrank force-pushed the fix/1753-add-opens-module-to-scripts branch from 48e6bd9 to 0d0dd32 Compare October 14, 2024 17:31
Copy link

codacy-production bot commented Oct 14, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% 0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (6fc92e6) 65145 0 0.00%
Head commit (0d0dd32) 65144 (-1) 0 (+0) 0.00% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1754) 1 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@robfrank robfrank merged commit 4207821 into main Oct 14, 2024
9 of 10 checks passed
@robfrank robfrank deleted the fix/1753-add-opens-module-to-scripts branch October 14, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors due to inaccessible modules (reflections?)
1 participant