New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix infinite loop in wpull.url.query_to_map #401

Open

tsudoko wants to merge 2 commits into ArchiveTeam:master from tsudoko:p/fix-query_to_map

tsudoko commented Nov 2, 2018 •

edited

Loading

I remembered to:

Update or add unit tests if needed
Update or add documentation/comments if needed
Made sure stray files or whitespace didn't get committed
If significant changes, branch from develop and set to merge into develop
Read the guidelines for contributing

URLInfo.query_map is a documented property, but it seems no one has used it ever, since it's been broken since its introduction 🤷

tsudoko added 2 commits

November 2, 2018 13:54


          Fix infinite loop in wpull.url.query_to_map

d5cc66b


          Add tests for wpull.url.query_to_map

75c3603

anarcat approved these changes

View reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet