Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bounced region name issue #223

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yonideshi
Copy link
Contributor

Bounced regions were named after track. Previous version of Ardour added "bounce" to the name. It seems that it was overlooked. Sometimes it is difficult to find bounced region when there are tens or hundred of regions on the list. Methods new_audio_source_path and new_midi_source_path correctly enumerate and "legalize" files paths. Probably this suffix could be added a region name only.

@pauldavisthefirst
Copy link
Contributor

This commit will break for multichannel tracks, because you've removed the channel number from the name. I like the general idea. Care to fix that particular problem?

@yonideshi
Copy link
Contributor Author

  1. "base_name" was unused variable, so channel info was not considered in this part of code
  2. "new_audio_source_path" method calls "legalize_for_path" internally and then rebuilds file name correctly using channel number information
  3. Summarizing: "new_audio_source_path" method previously took "/path/file_name" rebuild it with channel info and took care of collisions. With this commit it will take "/path/file_name-bounce" and will follow as before.

Thanks.

@luzpaz
Copy link
Contributor

luzpaz commented Jun 26, 2023

Is this ticket still relevant ?

@pauldavisthefirst
Copy link
Contributor

hard to say. It's not an issue I've seen raised over the lat 6 years ....

@luzpaz
Copy link
Contributor

luzpaz commented Sep 23, 2023

@yonideshi are you planning to follow-up ?

@x42
Copy link
Member

x42 commented Sep 23, 2023

Since Ardour 6.3 (specifically f564c92 and 80a7d32) there is a prompt for new region-names to mitigate this issue.
Rather than unconditionally adding a "bounce" suffix the user is prompted to specify a name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants