Some audio backend cleanup / refactor #943
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ary enum StandardDeviceName The StandardDeviceName enum was misleadingly *not* the name - the name only came from get_standard_device_name. Instead, simplify things, and just use two different trivial getters.
The description of is_realtime() did not match its actual use. And client_real_time_priority() did not have any description. It was hard to come up with good descriptions of what they actually did. Most backends returned true from is_realtime(), but every one except JACK used the default implementation of client_real_time_priority() that returned 0 ... which is exactly the same as when is_realtime() returns false. Just merge them and keep it simple.
The thing called backend_client_name defaulted to lowercase PROGRAM_NAME
and could be controlled with:
-c, --name <name> Use a specific backend client name, default is ardour
This value was *only* used for set_backend arg2 which only is used for
jack, where it was called session_uuid and passed to jack_client_open as
"a SessionID Token this allows the sessionmanager to identify the client
again" because JackSessionID.
It is certainly misleading to call it a uuid. It also doesn't seem
helpful to call it "client name" when the documentation calls it
"session id". And mostly: jack_client_open calls its *first* argument
"client_name" and it comes from argv1.
To clear things up, consistently call it something with "session id".
And it is not helpful to use a generic arg2 naming.
This parameter is consistently used to name the audio backend instance and how it appear as client of the sound server. Just name it `client_name`, consistent with the name of the jack_client_open parameter it is passed to .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.