Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n markup added #48

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

BloodSakura3774
Copy link

I used regular expressions to do the markup.
Both logging and output/display strings are marked.
I'm not sure about some of them so please double check my work before merging. And I'm not certain about some of the formated, please notice me if the format isn't right and I'll fix them. I might added too much or missed some.

Both logging and output/display strings are marked, please double check before merging
@amilcarlucas
Copy link
Collaborator

Does the code still run? Have you tested it?

@BloodSakura3774
Copy link
Author

Does the code still run? Have you tested it?

Didn’t test it, I don’t think the code will run without implementing the library first.
Will test later

@BloodSakura3774
Copy link
Author

Does the code still run? Have you tested it?

It won't run without gettext is implemented,
Syntax error in ...\MethodicConfigurator\ardupilot_methodic_configurator.py
File "...\MethodicConfigurator\ardupilot_methodic_configurator.py", line 50
_('parameters. The GUI reads intermediate parameter files from a directory and ')
^
SyntaxError: invalid syntax

@amilcarlucas
Copy link
Collaborator

amilcarlucas commented Sep 24, 2024

This week I'm really busy can you add commits that start the gettext implementation?

@BloodSakura3774
Copy link
Author

I can try to finish this

implemented and tested, it compiles, installs, and also runs.
@BloodSakura3774
Copy link
Author

BloodSakura3774 commented Sep 29, 2024

implemented, and tested that it works.
only thing left is exporting those marked string and translate them.
Also it is currently set to zh-cn in the new file internationalization.py
I believe we will need to compile multiple .exe for release after this is merged.
*looks like the folder locale is not present, please add one yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants