Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use absolute import to avoid circular imports. #914

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use absolute import to avoid circular imports. #914

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ed8d27
Use absolute import to avoid circular imports.
ScottHo Feb 1, 2024
485576b
Merge branch 'master' into pr-913_circular_import
ScottHo Feb 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion generator/mavparse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,7 +456,7 @@ def __str__(self):
def message_checksum(msg):
'''calculate CRC-16/MCRF4XX checksum of the key fields of a message, so we
can detect incompatible XML changes'''
from .mavcrc import x25crc
from pymavlink.generator.mavcrc import x25crc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how is this circular? mavcrc.py doesn't include this module

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the cause of the issue is I had a partially initialized module due to another python module of the same name.

This fixes it though and is more robust anyways in my opinion

AttributeError: partially initialized module 'mavcrc' has no attribute 'x25crc' (most likely due to a circular import)

crc = x25crc()
crc.accumulate_str(msg.name + ' ')
# in order to allow for extensions the crc does not include
Expand Down