-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Big fix branch for 2021 #296
Conversation
375c3f3
to
aacfdb2
Compare
1fe709a
to
413fc62
Compare
ac9f0ea
to
1c53896
Compare
1c53896
to
f5a4bad
Compare
5683991
to
1676b43
Compare
1676b43
to
1ee342c
Compare
I have two fixes you can cherry-pick from the branch 2021-02-15_beta.update. The first one is trivial, but the second one about the With the |
@hlovdal It doesn't look like there's too much to bring over ianfixes/arduino_ci@2021-02-15_beta...hlovdal:2021-02-15_beta.update |
@jgfoster I'll try to break this up into smaller pieces so we can get it merged in, but I'm not sure which of the issues fixed (see PR description) are most pressing |
@ianfixes, That's fine. As you have seen, I've merged most of my changes. The one remaining is the one to build a library once and use it for the remaining tests. While this has had an enormous speed improvement in our application, I'm not seeing the same improvement in the TestSomething case. For that reason I'm holding back and on merging it till I can better document the improvement. As to the other PRs, I do intend to review them and merge them as I understand what is happening (I've given my own preferential treatment since I understand them!). |
There are a lot of interrelated things to fix, so this branch intends to be a heavy-handed attempt to combine all those fixes.
Highlights from
CHANGELOG.md
Issues Fixed
before(:each)
rather thanbefore(:all)
#289