Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the initial APP_URL in the docker-compose.yml file so that development works out of the box #354

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Burzo
Copy link

@Burzo Burzo commented Nov 18, 2023

The fix is connected to this comment.

I was thinking about putting in a URL check where sails.config.appUrl is used, but that would just complicate everything in my opinion. For now, I think it's best if we simply fix the initial issue.

With this change, the MacOS and Windows auto-update feature of the dockerized app will work out of the box.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant