Merge pull request #46 from derekgengenbacher-wf/XMAS-4399

XMAS-4399 - Update auto versioning to permanently change setup.py during build
Arelle · Jun 25, 2019 · 5284ee3 · 5284ee3
2 parents 1d26608 + e89807d
commit 5284ee3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/Dockerfile b/Dockerfile
@@ -32,6 +32,8 @@ RUN mkdir /test_reports
 RUN nosetests --with-xunit --xunit-file=/test_reports/results.xml --cover-html tests.unit_tests
 
 # pypi package creation
+# The following command replaces the @VERSION@ string in setup.py with the tagged version number from GIT_TAG
+RUN sed -i s/@VERSION@/$GIT_TAG/ setup.py
 ARG BUILD_ARTIFACTS_PYPI=/build/dist/*.tar.gz
 RUN python setup.py sdist
 

diff --git a/setup.py b/setup.py
@@ -3,7 +3,7 @@
 
 setup(
     name='ixbrl_viewer',
-    version=os.getenv('GIT_TAG', '0.0.0'),
+    version='@VERSION@',
     description='The Workiva iXBRL Viewer allows iXBRL reports to be viewed interactively in a web browser',
     long_description=open('README.md').read(),
     url='https://github.com/workiva/ixbrl-viewer',