-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add nakama and evm docker image version on world.toml explanation #813
docs: add nakama and evm docker image version on world.toml explanation #813
Conversation
Your org has enabled the Graphite merge queue for merging into mainAdd the label “graphite/merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
WalkthroughThe pull request introduces new configuration parameters in the documentation for both the Ethereum Virtual Machine (EVM) and Nakama. Specifically, it adds Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Preview InstructionsTo preview these changes locally, checkout this branch and run:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 10
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
📒 Files selected for processing (2)
docs/cardinal/game/configuration/evm.mdx
(2 hunks)docs/cardinal/game/configuration/nakama.mdx
(2 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/cardinal/game/configuration/nakama.mdx
[uncategorized] ~83-~83: You might be missing the article “the” here.
Context: ...FORM Set nakama docker image platform, default value will follow the os platform. this...
(AI_EN_LECTOR_MISSING_DETERMINER_THE)
28c657b
to
2ed6766
Compare
Preview InstructionsTo preview these changes locally, checkout this branch and run:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 6
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
📒 Files selected for processing (2)
docs/cardinal/game/configuration/evm.mdx
(2 hunks)docs/cardinal/game/configuration/nakama.mdx
(2 hunks)
🧰 Additional context used
📓 Learnings (2)
docs/cardinal/game/configuration/evm.mdx (2)
Learnt from: ezavada
PR: Argus-Labs/world-engine#813
File: docs/cardinal/game/configuration/evm.mdx:96-97
Timestamp: 2024-11-19T15:23:54.453Z
Learning: For Cardinal v1.7.1 and later, the EVM image must be `v1.5.1` or later.
Learnt from: ezavada
PR: Argus-Labs/world-engine#813
File: docs/cardinal/game/configuration/evm.mdx:96-97
Timestamp: 2024-11-19T15:26:48.261Z
Learning: For Cardinal v1.6.x and earlier, the EVM image must be `v1.4.1` or earlier.
docs/cardinal/game/configuration/nakama.mdx (1)
Learnt from: ezavada
PR: Argus-Labs/world-engine#813
File: docs/cardinal/game/configuration/nakama.mdx:14-15
Timestamp: 2024-11-19T15:23:54.273Z
Learning: In `docs/cardinal/game/configuration/nakama.mdx`, differences in version numbers between the configuration block and the detailed examples for `NAKAMA_IMAGE` are intentional.
🔇 Additional comments (2)
docs/cardinal/game/configuration/nakama.mdx (1)
14-15
: LGTM! Configuration block is well-formatted.
The new configuration options are properly documented with appropriate quotation marks for string values.
docs/cardinal/game/configuration/evm.mdx (1)
16-17
: LGTM! TOML syntax is correct.
The configuration parameters are properly formatted with quoted string values, following TOML syntax guidelines.
Closes: WORLD-1274
Overview
Add explanation in world.toml to use specific nakama and evm docker image using
NAKAMA_IMAGE
,NAKAMA_IMAGE_PLATFORM
,EVM_MAGE
, andEVM_IMAGE_PLATFORM
Brief Changelog
add section on
/cardinal/game/configuration/nakama
and/cardinal/game/configuration/evm
Testing and Verifying
Summary by CodeRabbit
New Features
EVM_IMAGE
andEVM_IMAGE_PLATFORM
, enhancing user customization options.NAKAMA_IMAGE
andNAKAMA_IMAGE_PLATFORM
, allowing users to specify image versions and platforms.Documentation