fix: issue with end_idx inferring int type from variant type #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vars cannot be inferred using := from variant types, this was breaking the types of the file in the editor. I fixed it by using `mini` instead of `min` so that you can correctly get an int type rather than a variant
|
@Ark2000 this is a tiny fix, should be easy to merge. If there is an specific way you'd like MR's please let me know as I would love to contribute to your project. I can have a look at the open issues and roadmap in the future, this is more of a tiny fix to test your process |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
var types cannot be inferred using := from variant types so I used
miniinstead ofminto correctly return an int type