feat(parser, tests): improving diagnostics and tests for incomplete m…

…acros, macro condition, and imports

src/arkreactor/Compiler/AST/Parser.cpp

@@ -360,7 +360,7 @@ namespace Ark::internal
                 {
                     std::string symbol;
                     if (!name(&symbol))
-                        errorWithNextToken(fmt::format("Expected a valid symbol to import, not `{}'", symbol));
+                        errorWithNextToken("Expected a valid symbol to import");
                     if (symbol == "*")
                         error(fmt::format("Glob patterns can not be separated from the package, use (import {}:*) instead", import_data.toPackageString()), symbol);
 
@@ -582,7 +582,7 @@ namespace Ark::internal
         if (auto value_if_true = nodeOrValue(); value_if_true.has_value())
             leaf->push_back(value_if_true.value().attachNearestCommentBefore(comment));
         else
-            errorWithNextToken("Expected a value");
+            errorWithNextToken("Expected a node or value after condition");
 
         comment.clear();
         newlineOrComment(&comment);

tests/unittests/resources/DiagnosticsSuite/compileTime/bad_glob_import.ark

@@ -0,0 +1 @@
+(import a :*)

tests/unittests/resources/DiagnosticsSuite/compileTime/bad_glob_import.expected

@@ -0,0 +1,5 @@
+At ) @ 1:13
+    1 | (import a :*)
+      | ^~~~~~~~~~~~~
+    2 |
+        Glob patterns can not be separated from the package, use (import a:*) instead

tests/unittests/resources/DiagnosticsSuite/compileTime/incomplete_macro.ark

@@ -0,0 +1 @@
+($ foo)

tests/unittests/resources/DiagnosticsSuite/compileTime/incomplete_macro.expected

@@ -0,0 +1,5 @@
+At ) @ 1:7
+    1 | ($ foo)
+      |       ^
+    2 |
+        Expected an argument list, atom or node while defining macro `foo'

tests/unittests/resources/DiagnosticsSuite/compileTime/invalid_import_symbol.ark

@@ -0,0 +1 @@
+(import a :123)

tests/unittests/resources/DiagnosticsSuite/compileTime/invalid_import_symbol.expected

@@ -0,0 +1,5 @@
+At 1 @ 1:12
+    1 | (import a :123)
+      |            ^~~
+    2 |
+        Expected a valid symbol to import

tests/unittests/resources/DiagnosticsSuite/compileTime/missing_cond_if_macro.ark

@@ -0,0 +1 @@
+($if)

tests/unittests/resources/DiagnosticsSuite/compileTime/missing_cond_if_macro.expected

@@ -0,0 +1,5 @@
+At ) @ 1:5
+    1 | ($if)
+      |     ^
+    2 |
+        $if need a valid condition

tests/unittests/resources/DiagnosticsSuite/compileTime/missing_function_body.ark

@@ -0,0 +1 @@
+(fun ())

tests/unittests/resources/DiagnosticsSuite/compileTime/missing_function_body.expected

@@ -0,0 +1,5 @@
+At ) @ 1:8
+    1 | (fun ())
+      |        ^
+    2 |
+        Expected a body for the function

tests/unittests/resources/DiagnosticsSuite/compileTime/missing_then_if_macro.ark

@@ -0,0 +1 @@
+($if true)

tests/unittests/resources/DiagnosticsSuite/compileTime/missing_then_if_macro.expected

@@ -0,0 +1,5 @@
+At ) @ 1:10
+    1 | ($if true)
+      |          ^
+    2 |
+        Expected a node or value after condition

tests/unittests/resources/DiagnosticsSuite/compileTime/reused_macro_arg.ark

@@ -0,0 +1 @@
+($ foo (bar bar egg) ())

tests/unittests/resources/DiagnosticsSuite/compileTime/reused_macro_arg.expected

@@ -0,0 +1,5 @@
+At b @ 1:13
+    1 | ($ foo (bar bar egg) ())
+      |             ^~~
+    2 |
+        Argument names must be unique, can not reuse `bar'