refactor: removing more dead code

include/Ark/Compiler/NameResolutionPass.hpp

@@ -2,7 +2,7 @@
  * @file NameResolutionPass.hpp
  * @author Alexandre Plateau ([email protected])
  * @brief
- * @version 0.1
+ * @version 1.0
  * @date 2024-07-22
  *
  * @copyright Copyright (c) 2024
@@ -83,22 +83,6 @@ namespace Ark::internal
          */
         [[nodiscard]] bool isRegistered(const std::string& name) const;
 
-        /**
-         * @brief Returns false if we have only one scope (global), checks the scopes recursively for 'name'
-         *
-         * @param name
-         * @return
-         */
-        [[nodiscard]] bool isLocalVar(const std::string& name) const;
-
-        /**
-         * @brief 'name' has to be defined only in the first scope to be considered global
-         *
-         * @param name
-         * @return
-         */
-        [[nodiscard]] bool isGlobalVar(const std::string& name) const;
-
         /**
          * @brief Checks if 'name' is in the current scope
          *

include/Ark/Compiler/Pass.hpp

@@ -22,11 +22,6 @@ namespace Ark::internal
     class Pass
     {
     public:
-        /**
-         * @brief Construct a new Pass object
-         */
-        Pass();
-
         /**
          * @brief Construct a new Pass object
          *

include/Ark/Compiler/ValTableElem.hpp

@@ -2,7 +2,7 @@
  * @file ValTableElem.hpp
  * @author Alexandre Plateau ([email protected])
  * @brief The basic value type handled by the compiler
- * @version 0.2
+ * @version 1.0
  * @date 2020-10-27
  *
  * @copyright Copyright (c) 2020-2024
@@ -39,11 +39,6 @@ namespace Ark::internal
         std::variant<double, std::string, std::size_t> value;
         ValTableElemType type;
 
-        // Numbers
-        explicit ValTableElem(double num) noexcept;
-        explicit ValTableElem(long num) noexcept;
-        // Strings
-        explicit ValTableElem(const std::string& str) noexcept;
         // automatic handling (Number/String/Function)
         explicit ValTableElem(const Node& node) noexcept;
         // Functions

include/Ark/VM/Value.hpp

@@ -2,7 +2,7 @@
  * @file Value.hpp
  * @author Default value type handled by the virtual machine
  * @brief
- * @version 1.2
+ * @version 2.0
  * @date 2024-04-20
  *
  * @copyright Copyright (c) 2020-2024
@@ -102,10 +102,8 @@ namespace Ark
         {}
 
         explicit Value(int value) noexcept;
-        explicit Value(float value) noexcept;
         explicit Value(double value) noexcept;
         explicit Value(const std::string& value) noexcept;
-        explicit Value(const char* value) noexcept;
         explicit Value(internal::PageAddr_t value) noexcept;
         explicit Value(ProcType value) noexcept;
         explicit Value(std::vector<Value>&& value) noexcept;

include/Ark/VM/Value/Closure.hpp

@@ -2,7 +2,7 @@
  * @file Closure.hpp
  * @author Alexandre Plateau ([email protected])
  * @brief Subtype of the value type, handling closures
- * @version 1.1
+ * @version 2.0
  * @date 2024-04-21
  *
  * @copyright Copyright (c) 2020-2024
@@ -36,20 +36,6 @@ namespace Ark::internal
     class Closure
     {
     public:
-        /**
-         * @brief Construct a new Closure object
-         *
-         */
-        Closure() noexcept;
-
-        /**
-         * @brief Construct a new Closure object
-         *
-         * @param scope the scope of the function turned into a closure
-         * @param pa the current page address of the function turned into a closure
-         */
-        Closure(Scope&& scope, PageAddr_t pa) noexcept;
-
         /**
          * @brief Construct a new Closure object
          *

src/arkreactor/Compiler/NameResolutionPass.cpp

@@ -66,22 +66,6 @@ namespace Ark::internal
             });
     }
 
-    bool ScopeResolver::isLocalVar(const std::string& name) const
-    {
-        // only one scope, this is the global one
-        if (m_scopes.size() == 1)
-            return false;
-        return m_scopes.back().has(name);
-    }
-
-    bool ScopeResolver::isGlobalVar(const std::string& name) const
-    {
-        if (m_scopes.size() == 1)
-            return m_scopes[0].has(name);
-        // for a variable to be considered global, it has to not be shadowed in the current local scope
-        return !m_scopes.back().has(name) && m_scopes[0].has(name);
-    }
-
     bool ScopeResolver::isInScope(const std::string& name) const
     {
         return m_scopes.back().has(name);

src/arkreactor/Compiler/Pass.cpp

@@ -3,10 +3,6 @@
 
 namespace Ark::internal
 {
-    Pass::Pass() :
-        m_logger("", 0)
-    {}
-
     Pass::Pass(std::string name, const unsigned debug_level) :
         m_logger(std::move(name), debug_level)
     {}

src/arkreactor/Compiler/ValTableElem.cpp

@@ -2,21 +2,6 @@
 
 namespace Ark::internal
 {
-    ValTableElem::ValTableElem(double num) noexcept :
-        value(num),
-        type(ValTableElemType::Number)
-    {}
-
-    ValTableElem::ValTableElem(const long num) noexcept :
-        value(static_cast<double>(num)),
-        type(ValTableElemType::Number)
-    {}
-
-    ValTableElem::ValTableElem(const std::string& str) noexcept :
-        value(str),
-        type(ValTableElemType::String)
-    {}
-
     ValTableElem::ValTableElem(const Node& node) noexcept
     {
         if (node.nodeType() == NodeType::Number)

src/arkreactor/VM/Value.cpp

@@ -22,10 +22,6 @@ namespace Ark
         m_type(ValueType::Number), m_value(static_cast<double>(value))
     {}
 
-    Value::Value(const float value) noexcept :
-        m_type(ValueType::Number), m_value(static_cast<double>(value))
-    {}
-
     Value::Value(double value) noexcept :
         m_type(ValueType::Number), m_value(value)
     {}
@@ -34,10 +30,6 @@ namespace Ark
         m_type(ValueType::String), m_value(value)
     {}
 
-    Value::Value(const char* value) noexcept :
-        m_type(ValueType::String), m_value(value)
-    {}
-
     Value::Value(internal::PageAddr_t value) noexcept :
         m_type(ValueType::PageAddr), m_value(value)
     {}

src/arkreactor/VM/Value/Closure.cpp

@@ -6,16 +6,6 @@
 
 namespace Ark::internal
 {
-    Closure::Closure() noexcept :
-        m_scope(nullptr),
-        m_page_addr(0)
-    {}
-
-    Closure::Closure(Scope&& scope, const PageAddr_t pa) noexcept :
-        m_scope(std::make_shared<Scope>(scope)),
-        m_page_addr(pa)
-    {}
-
     Closure::Closure(const Scope& scope, const PageAddr_t pa) noexcept :
         m_scope(std::make_shared<Scope>(scope)),
         m_page_addr(pa)

tests/unittests/resources/LangSuite/vm-tests.ark

@@ -30,6 +30,7 @@
     (test:case "arithmetic operations" {
         (test:eq (+ 1 2) 3)
         (test:eq (+ 1.5 2.5) 4.0)
+        (test:eq (+ "a" "b") "ab")
         (test:eq (- 1 2) -1)
         (test:eq (- 1.5 2) -0.5)
         (test:eq (/ 1 2) 0.5)