fix(macro processor): set max macro processing depth to 256

ArkScript-lang · Jul 7, 2024 · c1c39c6 · c1c39c6
1 parent 8d49e31
commit c1c39c6
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/include/Ark/Constants.hpp.in b/include/Ark/Constants.hpp.in
@@ -52,7 +52,7 @@ namespace Ark
     // Default features for the VM x Compiler x Parser
     constexpr uint16_t DefaultFeatures = FeatureRemoveUnusedVars | FeatureShowWarnings;
 
-    constexpr std::size_t MaxMacroProcessingDepth = 1024;  ///< Controls the number of recursive calls to MacroProcessor::processNode
+    constexpr std::size_t MaxMacroProcessingDepth = 256;  ///< Controls the number of recursive calls to MacroProcessor::processNode
     constexpr std::size_t MaxMacroUnificationDepth = 256;  ///< Controls the number of recursive calls to MacroProcessor::unify
     constexpr std::size_t VMStackSize = 8192;
 }

diff --git a/src/arkreactor/Compiler/Macros/Processor.cpp b/src/arkreactor/Compiler/Macros/Processor.cpp
@@ -621,6 +621,6 @@ namespace Ark::internal
 
     void MacroProcessor::throwMacroProcessingError(const std::string& message, const Node& node)
     {
-        throw CodeError(message, node.filename(), node.line(), node.col(), "");  // node.repr()
+        throw CodeError(message, node.filename(), node.line(), node.col(), node.repr());
     }
 }
diff --git a/tests/errors/macros/max_depth.expected b/tests/errors/macros/max_depth.expected
@@ -1,2 +1,2 @@
 At / @ 1:0
-        Max recursion depth reached (1024). You most likely have a badly defined recursive macro calling itself without a proper exit condition
+        Max recursion depth reached (256). You most likely have a badly defined recursive macro calling itself without a proper exit condition