Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various tweaks #464

Merged
merged 11 commits into from
May 27, 2024
Merged

Various tweaks #464

merged 11 commits into from
May 27, 2024

Conversation

SuperFola
Copy link
Member

Description

  • chore: updating the examples to use the new syntax for imports, and removing the (fake) quoting
  • ci: adding a fuzzing job in the CI (closes CI: add a fuzzing step #422)
  • docs: removing markdown files from docs/ and moving them to the website so that doxygen doesn't generate them under a random new link every time
  • refactor: enhancing code with Clion's Nova help
  • refactor(welder): mutualising code

Checklist

  • I have read the Contributor guide
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation if needed
  • I have added tests that prove my fix/feature is working
  • New and existing tests pass locally with my changes

Copy link

github-actions bot commented May 26, 2024

Static analysis report

Lizard report

Listing only functions with cyclomatic complexity >= 15 or NLOC >= 100 or parameters >= 6.

Filename Start line:end line Function name Parameters NLOC CCN
src/arkreactor/VM/VM.cpp 258:1066 Ark::VM::safeRun 2 653 167
src/arkreactor/Compiler/BytecodeReader.cpp 70:438 Ark::BytecodeReader::display 4 327 131
src/arkreactor/Compiler/Macros/Processor.cpp 215:457 Ark::internal::MacroProcessor::evaluate 2 204 72
include/Ark/Compiler/AST/Parser.hpp 84:175 Ark::internal::ARK_APIParser::string 0 89 34
src/arkscript/main.cpp 17:300 main 2 246 30
src/arkreactor/Compiler/Compiler.cpp 534:639 Ark::Compiler::handleCalls 5 78 27
src/arkreactor/Compiler/Compiler.cpp 261:350 Ark::Compiler::compileExpression 5 73 24
src/arkreactor/Compiler/AST/Node.cpp 209:279 Ark::internal::Node::debugPrint 1 61 23
src/arkscript/JsonCompiler.cpp 23:188 JsonCompiler::_compile 1 139 23
src/arkreactor/VM/State.cpp 147:287 Ark::State::configure 0 116 22
include/utf8.hpp 138:184 utf8::isValid 1 44 21
src/arkreactor/Compiler/Macros/Processor.cpp 118:181 Ark::internal::MacroProcessor::processNode 2 48 20
src/arkreactor/Compiler/AST/Parser.cpp 263:373 Ark::internal::Parser::import_ 0 89 19
src/arkreactor/Compiler/Macros/Executors/Function.cpp 12:86 Ark::internal::FunctionExecutor::applyMacro 1 60 18
src/arkreactor/Compiler/AST/Node.cpp 143:207 Ark::internal::Node::repr 0 56 17
src/arkreactor/VM/Value.cpp 77:135 Ark::Value::toString 1 46 17
include/Ark/Compiler/AST/Predicates.hpp 162:186 Ark::internal::IsSymbol::operator ( ) 1 24 16
src/arkreactor/Compiler/Macros/Processor.cpp 53:98 Ark::internal::MacroProcessor::registerMacro 1 41 16
src/arkreactor/TypeChecker.cpp 27:78 Ark::types::displayContract 2 45 15
src/arkscript/Formatter.cpp 115:168 Formatter::format 3 51 15
src/arkreactor/Exceptions.cpp 124:133 Ark::Diagnostics::helper 8 9 3
include/Ark/Exceptions.hpp 92:101 Ark::CodeError::CodeError 6 10 1
Report about files you didn't modify in this PR
Filename Start line:end line Function name Parameters NLOC CCN

CppCheck report

Filename Line Type Description
include/Ark/Compiler/AST/Optimizer.hpp 63 style Unused private function 'Optimizer throwOptimizerError'
include/Ark/Compiler/AST/Parser.hpp 179 style Local variable 'symbol' shadows outer function
include/Ark/Compiler/AST/Predicates.hpp 117 performance Function parameter 'c' should be passed by const reference.
include/Ark/Compiler/AST/utf8_char.hpp 28 style Local variable 'codepoint' shadows outer function
include/Ark/TypeChecker.hpp 69 performance Function parameter 'name' should be passed by const reference.
include/Ark/TypeChecker.hpp 73 performance Function parameter 'name' should be passed by const reference.
src/arkreactor/Builtins/IO.cpp 192 style Consider using std transform algorithm instead of a raw loop.
src/arkreactor/Builtins/IO.cpp 24 style Parameter 'n' can be declared with const
src/arkreactor/Builtins/IO.cpp 43 style Parameter 'n' can be declared with const
src/arkreactor/Compiler/AST/BaseParser.cpp 310 style Consider using std any_of algorithm instead of a raw loop.
src/arkreactor/Compiler/AST/BaseParser.cpp 350 style Consider using std any_of algorithm instead of a raw loop.
src/arkreactor/Compiler/Compiler.cpp 140 style Consider using std copy algorithm instead of a raw loop.
src/arkreactor/Compiler/Compiler.cpp 160 style Consider using std copy algorithm instead of a raw loop.
src/arkreactor/Compiler/Compiler.cpp 167 style Consider using std copy algorithm instead of a raw loop.
src/arkreactor/Compiler/ImportSolver.cpp 144 style Consider using std transform algorithm instead of a raw loop.
src/arkreactor/Compiler/Macros/Executors/Function.cpp 14 style The scope of the variable 'first' can be reduced.
src/arkreactor/TypeChecker.cpp 80 performance Function parameter 'funcname' should be passed by const reference.
src/arkreactor/VM/Future.cpp 10 performance Variable 'm_value' is assigned in constructor body. Consider performing initialization in initialization list.
src/arkreactor/VM/Scope.cpp 51 style Variable 'id' is not assigned a value.
src/arkreactor/VM/Scope.cpp 61 style Variable 'id' is not assigned a value.
src/arkreactor/VM/Scope.cpp 71 style Variable 'id' is not assigned a value.
src/arkreactor/VM/State.cpp 124 style Consider using std transform algorithm instead of a raw loop.
src/arkreactor/VM/VM.cpp 555 style Consider using std copy algorithm instead of a raw loop.
src/arkreactor/VM/VM.cpp 602 style Consider using std copy algorithm instead of a raw loop.
src/arkscript/Formatter.cpp 438 warning Either the condition 'node.constList().empty()' is redundant or expression 'node.constList().back()' cause access out of bounds.
src/arkscript/main.cpp 141 style Consider using std copy algorithm instead of a raw loop.
src/arkscript/main.cpp 148 style Consider using std copy algorithm instead of a raw loop.

@SuperFola SuperFola force-pushed the various-tweaks branch 19 times, most recently from 997061f to a7d3e2b Compare May 26, 2024 18:31
@SuperFola SuperFola merged commit df29728 into dev May 27, 2024
17 checks passed
@SuperFola SuperFola deleted the various-tweaks branch May 27, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: add a fuzzing step
1 participant