Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/macro proc on windows #484

Merged
merged 4 commits into from
Jul 28, 2024
Merged

Fix/macro proc on windows #484

merged 4 commits into from
Jul 28, 2024

Conversation

SuperFola
Copy link
Member

Description

Bring Windows to parity with the Linux & MacOS builds. The default stack size on Windows is only 1MB, and it is used for many things among recursive calls, which the macro processor makes heavy use of.

Closes #482

Checklist

  • I have read the Contributor guide
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation if needed
  • I have added tests that prove my fix/feature is working
  • New and existing tests pass locally with my changes

Copy link

github-actions bot commented Jul 28, 2024

Static analysis report

Lizard report

Listing only functions with cyclomatic complexity >= 15 or NLOC >= 100 or parameters >= 6.

Filename Start line:end line Function name Parameters NLOC CCN
src/arkreactor/Compiler/Macros/Processor.cpp 276:568 Ark::internal::MacroProcessor::evaluate 3 276 110
src/arkreactor/Compiler/Macros/Processor.cpp 127:197 Ark::internal::MacroProcessor::processNode 2 54 21
src/arkreactor/Compiler/Macros/Processor.cpp 56:101 Ark::internal::MacroProcessor::registerMacro 1 41 16
Report about files you didn't modify in this PR
Filename Start line:end line Function name Parameters NLOC CCN
src/arkreactor/VM/VM.cpp 266:1100 Ark::VM::safeRun 2 674 169
src/arkreactor/Compiler/BytecodeReader.cpp 199:488 Ark::BytecodeReader::display 4 258 120
src/arkreactor/Compiler/Compiler.cpp 567:696 Ark::Compiler::handleCalls 5 101 35
include/Ark/Compiler/AST/Parser.hpp 84:173 Ark::internal::ARK_APIParser::string 0 87 32
src/arkscript/main.cpp 17:302 main 2 248 28
src/arkreactor/Compiler/Compiler.cpp 277:368 Ark::Compiler::compileExpression 5 75 25
src/arkscript/JsonCompiler.cpp 23:188 JsonCompiler::_compile 1 139 23
src/arkreactor/Compiler/AST/Node.cpp 209:279 Ark::internal::Node::debugPrint 1 61 23
include/utf8.hpp 138:184 utf8::isValid 1 44 21
src/arkreactor/Compiler/AST/Parser.cpp 269:396 Ark::internal::Parser::import_ 0 103 21
src/arkreactor/Compiler/Macros/Executors/Function.cpp 12:86 Ark::internal::FunctionExecutor::applyMacro 2 60 18
src/arkreactor/VM/Value.cpp 77:135 Ark::Value::toString 1 46 17
src/arkreactor/Compiler/AST/Node.cpp 143:207 Ark::internal::Node::repr 0 56 17
include/Ark/Compiler/AST/Predicates.hpp 162:186 Ark::internal::IsSymbol::operator ( ) 1 24 16
src/arkreactor/Exceptions.cpp 79:125 Ark::Diagnostics::makeContext 5 34 16
src/arkscript/Formatter.cpp 153:206 Formatter::format 3 51 15
src/arkreactor/TypeChecker.cpp 27:78 Ark::types::displayContract 2 45 15
src/arkreactor/Exceptions.cpp 128:137 Ark::Diagnostics::helper 8 9 3
include/Ark/Exceptions.hpp 92:101 Ark::CodeError::CodeError 6 10 1

CppCheck report

Filename Line Type Description
include/Ark/Compiler/Macros/Processor.hpp 165 performance Function parameter 'origin' should be passed by const reference.
src/arkreactor/Compiler/Macros/Processor.cpp 27 performance Variable 'm_predefined_macros' is assigned in constructor body. Consider performing initialization in initialization list.
src/arkreactor/Compiler/Macros/Processor.cpp 255 performance Function parameter 'origin' should be passed by const reference.
Report files about files you didn't modify in this PR
Filename Line Type Description
src/arkreactor/Builtins/IO.cpp 24 style Parameter 'n' can be declared with const
src/arkreactor/Builtins/IO.cpp 43 style Parameter 'n' can be declared with const
src/arkreactor/Builtins/IO.cpp 192 style Consider using std::transform algorithm instead of a raw loop.
include/Ark/Compiler/AST/Optimizer.hpp 64 style Unused private function: 'Optimizer::throwOptimizerError'
include/Ark/Compiler/AST/Optimizer.hpp 70 style Unused private function: 'Optimizer::remove_unused'
src/arkreactor/Compiler/AST/Parser.cpp 388 error Uninitialized variable: import_data.with_prefix
src/arkreactor/Compiler/Macros/Executor.cpp 12 performance Function parameter 'origin' should be passed by const reference.
include/Ark/Compiler/Macros/Executor.hpp 65 performance Function parameter 'origin' should be passed by const reference.
src/arkreactor/Compiler/Macros/Executors/Function.cpp 14 style The scope of the variable 'first' can be reduced.
src/arkreactor/VM/Scope.cpp 51 style Variable 'id' is not assigned a value.
src/arkreactor/VM/Scope.cpp 61 style Variable 'id' is not assigned a value.
src/arkreactor/VM/Scope.cpp 71 style Variable 'id' is not assigned a value.

@SuperFola SuperFola force-pushed the fix/macro-proc-on-windows branch from 12f399f to 592a68a Compare July 28, 2024 11:24
…tly inside the MacroProcessor

It was in fact just a class to hold a vector and a single public method
to run a loop and call methods on the objects inside the vector.
@SuperFola SuperFola force-pushed the fix/macro-proc-on-windows branch from 592a68a to ac3b68e Compare July 28, 2024 11:30
@SuperFola SuperFola merged commit 853612e into dev Jul 28, 2024
20 checks passed
@SuperFola SuperFola deleted the fix/macro-proc-on-windows branch July 28, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Macro processor max depth error not thrown on Windows
1 participant